Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.1 glass is not allowing sunlight to go through when using the shader comp unbound #486

Closed
Thunderrock424242 opened this issue Nov 4, 2023 · 23 comments
Labels
bug Something isn't working

Comments

@Thunderrock424242
Copy link

What happened?

sunlight can't pass through glass

Screenshots

Screenshot 2023-11-03 212636 Screenshot 2023-11-03 212804

Relevant log output

No response

Minecraft Version

1.20.1

Oculus Version

1.6.9

Rubidium Version

n/a using embedium

Operating System

windows 11

What is your GPU?

nivida geforce rtx 4060 laptop

Java Version

java 17 i think

Additional context

No response

@Thunderrock424242 Thunderrock424242 added the bug Something isn't working label Nov 4, 2023
@gaussandhisgun
Copy link

this is a shader bug, try enabling stuff like colored shadows

@Thunderrock424242
Copy link
Author

this is a shader bug, try enabling stuff like colored shadows

The shader dev says it's a ocuals issue and iris does not have it

@MoonDew
Copy link

MoonDew commented Nov 19, 2023

this is a shader bug, try enabling stuff like colored shadows

The shader dev says it's a ocuals issue and iris does not have it

When will it get fixed? I can't use things like glass domes and glass roofs if they're going to cast shadows like this?

@PlayfulPiano
Copy link

image
can also confirm that oculus causes glass to apply a shadow when using complementary shaders. Using forge 1.20.1 with embeddium beta and oculus 1.6.9 1.20.1.

@PlayfulPiano
Copy link

IMS figured out the issue:
image

@Shadowdane
Copy link

This issue also happens on Oculus 1.18.2-1.6.4. So it's not exclusive to just 1.20.1. Been playing Vault Hunters with shaders and noticed that light doesn't pass through glass.

Minecraft Version
1.18.2

Oculus Version
1.6.4

Rubidium Version
0.5.6

Operating System
windows 11

What is your GPU?
Nvidia RTX 4080

Java Version
17.0.9

Forge Version
40.2.9

2023-12-03_12 30 04

@embeddedt
Copy link

Please check if this is fixed when using 1.6.13.

@Thunderrock424242
Copy link
Author

I will test it out when I get a chance

@Thunderrock424242
Copy link
Author

Please check if this is fixed when using 1.6.13.

Pretty sure it's fixed I tested it and looks good

@Shadowdane
Copy link

Please check if this is fixed when using 1.6.13.

Will this fix be ported back to the 1.18.2 build as well?
Or should I fill a different bug report for that version specifically?

@embeddedt
Copy link

I'm not sure 1.18 will receive another update.

@GarthF
Copy link

GarthF commented Jan 3, 2024

I'm running 1.6.13 and still have the shadowed glass issue.

image

@Thunderrock424242
Copy link
Author

Damn

@PlayfulPiano
Copy link

damn

@embeddedt
Copy link

@GarthF What shader are you using?

@GarthF
Copy link

GarthF commented Jan 4, 2024

Complementary Shaders, both unbound and reimagined show the issue. Using them on the direwolf20 pack.
Unbound r5.1.1
Reimagined r5.1.1

Interestingly the cyclic clear glass is unaffected.
image

@embeddedt
Copy link

So I'm unable to reproduce this in a standalone instance, but if you can only get it to happen in a large modpack I have an idea of what the issue might be. Can you try this version and let me know if the behavior is any different?

oculus-testing.zip

@GarthF
Copy link

GarthF commented Jan 4, 2024

Ran the test Jar, unfortunately still seeing same shadow effect:
image

@embeddedt
Copy link

What mod are you using to make the vanilla glass have connected textures?

@GarthF
Copy link

GarthF commented Jan 4, 2024

I'm not sure what's being used for that, I'll trawl through the direwolf20 pack and see if I can spot anything.

@GarthF
Copy link

GarthF commented Jan 4, 2024

So, did some digging. Xycraft: Override looks like the mod thats doing it. Provides override textures for glass

@embeddedt
Copy link

Thanks. I looked through the mod list and saw the same thing, and I can indeed reproduce with just Xycraft's stuff installed.

@embeddedt
Copy link

I found the problem and solved it in the latest change to #529; when that is merged and released, XyCraft's overrides will not break shadows anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants