Commit 736529b
committed
Repeat position:fixed content on every page, per css-position-3
Verified against the actual W3C spec text (css-position-3): "in paged
media, the page area of each page; fixed positioned boxes are thus
replicated on every page", and UAs "must not paginate the content of
fixed-positioned boxes". Scoped to top/left-anchored fixed content only
(a page header/watermark) - bottom/right are a separate, pre-existing gap:
neither property is parsed for absolute/fixed positioning at all, so a
bottom-anchored footer, the more common real print pattern, needs that
fixed first.
FragmentEmitter now collects every position:fixed box in the tree
(CollectFixedRoots, handling arbitrary nesting depth) and, for each
materialized page, builds a fresh fragment for it against a page-local band
(top=0) rather than the page's real band top - a fixed box's own Location is
already page-relative (CssBox.PerformLayoutImp's Position==Fixed branch
never routes it through normal absolute-Y-computing flow at all), so this
reuses the same geometry unchanged on every page. Excluded from the normal
per-page walk to avoid a duplicate/misplaced render on whichever page its
raw offset would otherwise land on. InlineFragmentation.ApplyLineBreaking
now also skips fixed boxes outright - their content must not paginate.
Confirming this through actual PDF output (not just the fragment tree)
surfaced a second, real, pre-existing bug: FragmentPainter.LiveTreeOffset/
LiveTreeExtraOffset unconditionally undid the current page's band top from
live-tree geometry, on the documented assumption that "band membership is
orthogonal to scroll-offset suppression" for fixed content. That assumption
was true when fixed content only ever appeared on one page (wherever its
raw offset landed) but breaks now that it's intentionally repeated: a fixed
box's live geometry is already page-relative, so subtracting a nonzero band
top pushes its containing-block visibility/overflow-clip check far outside
every page except the one whose band top happens to equal its own small
offset - confirmed via a real generated PDF, where the header only rendered
on page 0. Fixed by making both offsets skip the band-top term entirely for
fixed (or fixed-ancestor) content.1 parent 68fbb66 commit 736529b
6 files changed
Lines changed: 248 additions & 12 deletions
File tree
- Source
- HtmlRenderer/Core
- Fragmentation
- Paint
- Content
- Test
- HtmlRenderer.IntegrationTest
- HtmlRenderer.PdfSharp.Test
Lines changed: 51 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| 7 | + | |
6 | 8 | | |
7 | 9 | | |
8 | 10 | | |
| |||
55 | 57 | | |
56 | 58 | | |
57 | 59 | | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
58 | 70 | | |
59 | 71 | | |
60 | 72 | | |
| |||
63 | 75 | | |
64 | 76 | | |
65 | 77 | | |
66 | | - | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
67 | 81 | | |
68 | 82 | | |
69 | 83 | | |
70 | 84 | | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
71 | 95 | | |
72 | 96 | | |
73 | 97 | | |
| |||
76 | 100 | | |
77 | 101 | | |
78 | 102 | | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
79 | 119 | | |
80 | 120 | | |
81 | 121 | | |
82 | 122 | | |
83 | 123 | | |
84 | 124 | | |
85 | | - | |
| 125 | + | |
86 | 126 | | |
87 | 127 | | |
88 | 128 | | |
| |||
103 | 143 | | |
104 | 144 | | |
105 | 145 | | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
106 | 153 | | |
107 | 154 | | |
108 | 155 | | |
| |||
156 | 203 | | |
157 | 204 | | |
158 | 205 | | |
| 206 | + | |
| 207 | + | |
159 | 208 | | |
160 | 209 | | |
161 | 210 | | |
| |||
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
41 | 42 | | |
42 | 43 | | |
43 | 44 | | |
44 | | - | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
45 | 51 | | |
46 | 52 | | |
47 | 53 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
85 | | - | |
86 | | - | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
87 | 89 | | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
88 | 105 | | |
89 | 106 | | |
90 | 107 | | |
91 | | - | |
| 108 | + | |
92 | 109 | | |
93 | 110 | | |
94 | 111 | | |
95 | 112 | | |
96 | | - | |
97 | | - | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
98 | 116 | | |
99 | | - | |
| 117 | + | |
| 118 | + | |
100 | 119 | | |
101 | 120 | | |
102 | 121 | | |
| |||
169 | 188 | | |
170 | 189 | | |
171 | 190 | | |
172 | | - | |
| 191 | + | |
173 | 192 | | |
174 | 193 | | |
175 | 194 | | |
| |||
Lines changed: 107 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
0 commit comments