Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repositories matching #95

Open
spykoulouris opened this issue Mar 15, 2022 · 8 comments
Open

Repositories matching #95

spykoulouris opened this issue Mar 15, 2022 · 8 comments
Assignees
Labels
bug Something isn't working validation needs verification before closing

Comments

@spykoulouris
Copy link

The system allows user to make the same matching again and again. The reconciliation button appears again for repositories that I have already matched and when I click there it does the matching again. Here the example of the Musee du Petit Palais at Avignon matched twice.

Screenshot 2022-03-15 at 08 42 55

@spykoulouris spykoulouris added the bug Something isn't working label Mar 15, 2022
@mafragias
Copy link
Contributor

This is not a bug, the two instances from Zeri are seemingly the same, but are actually different, due to the Precise location. This has implemented that way to make the URI of the repository as unique as possible, to avoid mistakes, since there is no ID provided. (In some cases there is not detailed information about Country/Town or Region, that's why we also take into account the Precise location)

  • image

  • image

@mafragias mafragias added the validation needs verification before closing label Mar 15, 2022
@spykoulouris
Copy link
Author

I see, that means that for the Zeri each repository may need to be reconciled multiple (sometimes too many) times?

@mafragias
Copy link
Contributor

Yes, but at least, we are certain we don't have merged repositories with the same name!!!!!!!!!!!

@spykoulouris
Copy link
Author

ok, I understand

@lklic
Copy link
Contributor

lklic commented Mar 16, 2022

Hi @spykoulouris and @mafragias. I think these should be reconciled to the same repository.

The precise location is the inventory number within that location and should be attached to the specific photograph, not the entity of the repository.

We should verify this with Francesca.

Thanks,
L

@lklic lklic reopened this Mar 16, 2022
@mafragias
Copy link
Contributor

I do not agree into changing the Repositories' URIs. It will in some cases cause the URIs to merge inconsistently , because it might not have all the other information like country or region and might only have the precise location. Like the example below :
image

@spykoulouris
Copy link
Author

"Mercato antiquario" and "ubicazione sconosciuta" are not real locations.
I see both benefits and risks here, we should talk with Francesca about this. However, making the reconciliation as it is now makes no sense. Sometimes (i.e. National Gallery of London) we will need to reconcile the same repository hundreds of times.

@lklic
Copy link
Contributor

lklic commented Mar 16, 2022

Please provide an extract in csv or link to the spraql query, we can review the data and decide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working validation needs verification before closing
Projects
None yet
Development

No branches or pull requests

5 participants