problem with exporting

[vcircus]

Hi, thanks for the nice plugin. Works as I need in the editor. Ran in to a problem with exporting to android: I get the error: "parser error: Could not find type "EditorPlugin" in the current scope. Which points to line 403 in collapsible_container.gd.

Tried it in Godot 4.1, 4.1.1 and 4.2 on a mac and version 4.2 on windows with same result. Tried a few things to fix it but am not much of a programmer :-(
Can you point me in a direction to fix this?
Thanks in advance.
Paul

[ArshvirGoraya]

@vcircus
Hey Paul, I can't replicate this error and everything seems to be exporting fine for me for android. Some pictures might help. If you want, you can also create a minimum reproduction project with only relevant stuff and send me a zipped folder of the project IF it contains the error as well. I'm also assuming that you are using version 1.0.0 of this plugin so let me know if that's wrong.

Some information/advice that MAY help

The EditorPlugin is a Godot class that this plugin uses when you want to undo/redo anything related to the CollapsibleContainer (e.g., when you press ctrl+z or ctrl+y) while in the editor. It is NOT needed or used when you're in game - only in the editor.

Because it's not needed in game, you could try to simply comment out that line, export, and then just uncomment that line after exporting. Let me know if that works or not.

Since I can't replicate the issue, I can't really help too much without more information.

[vcircus]

Hi Thanks for the quick reply. I made a simple project and put it on https://vcircus.stackstorage.com/s/nEANphmyb7lnboQA so you can have a look at what I put together. In this version i have out-commented the line and then it exports (as you suggested) Can’t export if the line is uncommented. If it exports I see another error ( "sizing node is null” ) Regards Paul

…

Op 6 dec. 2023, om 03:42 heeft Arshvir Goraya ***@***.***> het volgende geschreven: @vcircus <https://github.com/vcircus> Hey Paul, I can't replicate this error and everything seems to be exporting fine for me for android. Some pictures might help. If you want, you can also create a minimum reproduction project with only relevant stuff and send me a zipped folder of the project IF it contains the error as well. I'm also assuming that you are using version 1.0.0 of this plugin so let me know if that's wrong. Some information/advice that MAY help The EditorPlugin is a Godot class that this plugin uses when you want to undo/redo anything related to the CollapsibleContainer (e.g., when you press ctrl+z or ctrl+y) while in the editor. It is NOT needed or used when you're in game - only in the editor. Because it's not needed in game, you could try to simply comment out that line, export, and then just uncomment that line after exporting. Let me know if that works or not. Since I can't replicate the issue, I can't really help too much without more information. — Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AECBOO26PFEYPG2UIITRSEDYH7LRXAVCNFSM6AAAAABAHQJTCCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBRHE4TINJRGE>. You are receiving this because you were mentioned.

[ArshvirGoraya]

@vcircus

Hey, there seems to be 2 issues here.

Editor Plugin not being recognized on Android.

This seems like a Godot specific issue and I've filed an issue you can find here: godotengine/godot#86013

• ANY script trying to use the EditorPlugin class seems to throw this error on Android, not just this plugin.

Workaround: instead of commenting out the line anytime you export to android, simply remove the EditorPlugin type hint:
So instead of this old line var _editor_plugin : EditorPlugin
Use this new line: var _editor_plugin OR var _editor_plugin# : EditorPlugin

sizing_node is null.

I got this error from the zip file you sent.
Fix: It seems that when you enable "Small Deploy with Network FileSystem," it goes away.

With both these changes, I was able to export to android without a problem.

Please let me know if this fixes everything for you since I need to know whether to close this issue or not.

Sorry for not responding faster. Just got a job so can't give this my 100% attention.

[vcircus]

Hi Thanks for looking in to it. Will try the workarounds tomorrow evening. Found out that it also works if you fill in a number for the custom open size as well as for the custom close size. thanks, Paul

…

Op 10 dec. 2023, om 21:15 heeft Arshvir Goraya ***@***.***> het volgende geschreven: @vcircus <https://github.com/vcircus> Hey, there seems to be 2 issues here. Editor Plugin not being recognized on Android. This seems like a Godot specific issue and I've filled an issue you can find here: godotengine/godot#86013 <godotengine/godot#86013> ANY script trying to use the EditorPlugin class seems to throw this error on Android, no just this plugin. Workaround: instead of commenting out the line anytime you export to android, simply remove the EditorPlugin type hint: So instead of this old line var _editor_plugin : EditorPlugin Use this new line: var _editor_plugin OR var _editor_plugin# : EditorPlugin sizing_node is null. I got this error from in the folder you sent. Fix: It seems that when you enable "Small Deploy with Network FileSystem," it goes away. Screenshot.33.png (view on web) <https://github.com/ArshvirGoraya/Godot-Collapsible-Container/assets/113562877/e01d8192-8763-4b43-b6e9-3c0767aae46d> With both these changes, I was able to export to android without a problem. Please let me know if this fixes everything for you since I need to know whether to close this issue or not. Sorry I couldn't respond faster. Just got a job so can't give this my 100% attention. — Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AECBOO5B5E64NP5LMRUFVGLYIYJ5BAVCNFSM6AAAAABAHQJTCCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBZGA3TAOJZGY>. You are receiving this because you were mentioned.

[ArshvirGoraya]

Found out that it also works if you fill in a number for the custom open size as well as for the custom close size.

Yeah, the problem is the Collapsible node doesn't know what to size to because the sizing_node is not set. However, if you're using custom sizes, then the sizing_node isn't used.

The reason the sizing_node doesn't get set is because it's setter function does not automatically get called without the "Small Deploy with Network FileSystem" being enabled. I have no idea why this is.

The setter function is set_sizing_node_path(node_path). Since it doesn't get called automatically like it should, what you can do instead is call it yourself in some script's ready function. This will ALSO remove the sizing_node is null error. Alternatively, you can just do sizing_node = node_path_of_a_control_node and this TOO will call the set_sizing_node_path() setter function. All in all, the sizing_node's setter function isn't called automatically as it should which is causing the error, but you can set the sizing_node through code to avoid the error.

You shouldn't have to do any of this with the "Small Deploy with Network FileSystem" option enabled though.

P.S. I only tested all of this in one-click deploy exports and not with like an APK export. Would love it if you did a normal export and saw if it works on your phone before reporting that everything is working.

[vcircus]

Hi It works as you told with the one click deploy on a connected android device ( if the 'small deploy with network network filesystem’ is selected) But not if I make an APK file, then the issue is still there. Will try to set the sizing_node in the script as you suggest. Gonna try that tomorrow, today was a busy long day in a museum. Thanks for the help, and there is no hurry in solving this. Can work around it for now, but would be nice if there is a solution. regards Paul

…

Op 10 dec. 2023, om 23:02 heeft Arshvir Goraya ***@***.***> het volgende geschreven: Found out that it also works if you fill in a number for the custom open size as well as for the custom close size. Yeah, the problem is the Collapsible node doesn't know what to size to because the sizing_node is not set. However, if you're using custom sizes, then the sizing_node isn't used. The reason the sizing_node doesn't get set is because it's setter function does not automatically get called without the "Small Deploy with Network FileSystem" being enabled. I have no idea why this is. The setter function is set_sizing_node_path(node_path). Since it doesn't get called automatically like it should, what you can do instead is call it yourself in some script's ready function. This will ALSO remove the sizing_node is null error. Alternatively, you can just do sizing_node = node_path_of_a_control_node and this TOO will call the set_sizing_node_path() setter function. All in all, the sizing_node's setter function isn't called automatically as it should which is causing the error, but you can set the sizing_node through code to avoid the error. You shouldn't have to do any of this with the "Small Deploy with Network FileSystem" option enabled though. P.S. I only tested all of this in one-click deploy exports and not with like an APK export. Would love it if you did a normal export and saw if it works on your phone before reporting that everything is working. — Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AECBOO2QNPFWVTFV4M75QR3YIYWPZAVCNFSM6AAAAABAHQJTCCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBZGEYDANBQG4>. You are receiving this because you were mentioned.