Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deliveries without purchase #160

Open
alehaa opened this issue Apr 19, 2024 · 3 comments
Open

Allow deliveries without purchase #160

alehaa opened this issue Apr 19, 2024 · 3 comments

Comments

@alehaa
Copy link
Contributor

alehaa commented Apr 19, 2024

Sometimes there can be deliveries with no specific purchase. An example would be waranty hardware replacements. I therefore suggest making Delivery.purchase an optional field.

@matejv
Copy link
Member

matejv commented Jul 16, 2024

The code that handles asset import from CSV would have to account for this. It can automatically create new purchases and deliveries if a matching one does not exist yet.

Other than that it should be fairly straightforward to do.

@matejv
Copy link
Member

matejv commented Jul 16, 2024

Should a Delivery without purchase have a Supplier or not? Do we need to add Delivery.supplier field?

@alehaa
Copy link
Contributor Author

alehaa commented Jul 17, 2024

Hmm. Good point, I hadn't thought of that. It would make sense to have a supplier, since someone has to send the parts.

Perhaps another (and cleaner) way to implement this would be to use purchases linked to the warranty case instead of having a price attached? However, in this case I think we should add an option to select a manufacturer instead of a supplier for the purchase if the hardware is shipped directly from the manufacturer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants