Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions to build your project #3

Closed
DarkShadowNight opened this issue Dec 10, 2024 · 4 comments
Closed

Questions to build your project #3

DarkShadowNight opened this issue Dec 10, 2024 · 4 comments

Comments

@DarkShadowNight
Copy link

Hello,

I like your project, Yet I am not able to replicate.
Some general remarks, questions:

  • ADC_INTERNAL_REFERENCE_MILLIVOLT: Might need to explain how to measure to some less advanced users.
  • ADC_CHANNEL_VOLTAGE: Watch out it's channel and not pin numbers, took me quite some time to figure out!
  • ADC_CHANNEL_CURRENT / ADC_CHANNEL_LOGGER_CURRENT: What is the difference, I don't understand.
  • Why is the internal LED flashing (pin 13), Timer running for PWM buzzer?
  • ONLY_LOGGER_MODE_PIN: How it's measured when not connected to ground?
  • LOGGER_SHUNT_RESISTOR_MILLIOHM : How, why, when?
  • #define USE_PARALLEL_LCD //#define USE_SERIAL_LCD: Is this a nice way to switchover to I2C to comment and uncomment here?
    #define ONLY_PLOTTER_OUTPUT_PIN and #define ADC_CHANNEL_LOGGER_CURRENT is a disaster it suddenly redeclarates if you think you have done your declarations already.
  • #define LCD_COLUMNS 16 and #define LCD_ROWS 2: Not friendly on 20 * 4 display for erasing additional characters correctly.

Thanks

@ArminJo
Copy link
Owner

ArminJo commented Dec 11, 2024

Hi, thanks for the feedback 👍 .
I tried to document most of your concerns, maybe you can check again and update your feedback.
Logger functionality is not yet properly tested...

@DarkShadowNight
Copy link
Author

It is working now, thanks!
Why not include softwareserial for debugging / tracing?

https://github.com/salaiaungmyintmyat/OnePinOnly_SoftwareSerial

@ArminJo
Copy link
Owner

ArminJo commented Dec 12, 2024

Why not include softwareserial for debugging / tracing?

The standard serial is available for this, so why do you ask?

@ArminJo ArminJo closed this as completed Dec 12, 2024
@DarkShadowNight
Copy link
Author

DarkShadowNight commented Dec 14, 2024

Might be easy to have the debug output and trace output on a separate pin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants