yeah so substring doesn't modify in place

WispySparks · WispySparks · commit eceebae0f59e · 2024-10-28T15:35:27.000-05:00
diff --git a/source/assets/javascripts/main.js b/source/assets/javascripts/main.js
@@ -5,7 +5,7 @@ document.querySelectorAll("a").forEach((a) =>
     let currentPath = document.location.href;
     // Paths end with slashes in prod but not locally
     if (currentPath.endsWith("/")) {
-      currentPath.substring(0, currentPath.length - 1);
+      currentPath = currentPath.substring(0, currentPath.length - 1);
     }
     // Check if it points to the same page we're on
     if (href.includes("#") && href.startsWith(currentPath)) {

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ document.querySelectorAll("a").forEach((a) =>`
`5`	`5`	`let currentPath = document.location.href;`
`6`	`6`	`// Paths end with slashes in prod but not locally`
`7`	`7`	`if (currentPath.endsWith("/")) {`
`8`		`- currentPath.substring(0, currentPath.length - 1);`
	`8`	`+ currentPath = currentPath.substring(0, currentPath.length - 1);`
`9`	`9`	`}`
`10`	`10`	`// Check if it points to the same page we're on`
`11`	`11`	`if (href.includes("#") && href.startsWith(currentPath)) {`