Fix EepromMcuReadBuffer: Read back from cache #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read back information from cache instead of flash. The cache contains the latest context, whereas the flash is only updated periodically. This could cause issues if the flash is not (yet) updated while the context has been updated in the meantime and values are read by LoRaMAC. Therefore just read from flash initially after startup (EepromMcuInit()) and rely on write cache later. This commit effectively makes commit e31d3c1 work for me and therefore is a fix. Previous attemps to use commit e31d3c1... without this commit failed. Error message: "Duty cycle restricted". The error message might not appear at the first startup, but will appear if Raspberry Pi Pico is restarted and values from "EEPROM" / Flash have been read.
4 tasks
|
Restoring context after Raspberry restart works fine with this PR: First start with untouched Flash: Second start is much quicker (context is used): |
ThomasLeister
changed the title
|
Tested using:
Everything seems to work as expected, joins seem to happen quickly. |
sandeepmistry
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read back information from cache instead of flash.
The cache contains the latest context, whereas
the flash is only updated periodically.
This could cause issues if the flash is not (yet) updated
while the context has been updated in the meantime and values are read
by LoRaMAC.
Therefore just read from flash initially after startup (EepromMcuInit())
and rely on write cache later.
This commit effectively makes commit e31d3c1
work for me and therefore is a fix. Previous attemps to use commit
e31d3c1... without this commit failed. Error message: "Duty cycle restricted".
The error message might not appear at the first startup, but will
appear if Raspberry Pi Pico is restarted and values from "EEPROM" /
Flash have been read.
Might be related to #14 and also affects #15