Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten the link between Options and ConfigEntries #73

Open
Arkhist opened this issue Jul 23, 2021 · 1 comment
Open

Tighten the link between Options and ConfigEntries #73

Arkhist opened this issue Jul 23, 2021 · 1 comment

Comments

@Arkhist
Copy link
Owner

Arkhist commented Jul 23, 2021

Current implem does twice the work. Using ConfigEntries in the very beginning would make options easier to save.

@Arkhist Arkhist added the Feature Bloat ew, why label Jul 23, 2021
@Windows10CE
Copy link
Collaborator

Since BepInEx/BepInEx#267 is in the works it would probably be a good idea to hold off on this specific issue and discourage the use of the settings menu by modders till then, that PR should afford us some more flexibility in how we can integrate these config options.

We could also abstract away ConfigFile now and make the change transparent later, which might end up being better? Options haven't seen a ton of code written for them just yet other than the minimum for checkboxes, so if we decide to go that route now would be the time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants