Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relicense (to copyleft) #1

Open
Multfinite opened this issue Feb 17, 2024 · 14 comments · Fixed by #4
Open

Relicense (to copyleft) #1

Multfinite opened this issue Feb 17, 2024 · 14 comments · Fixed by #4

Comments

@Multfinite
Copy link
Contributor

Multfinite commented Feb 17, 2024

Hi. I am working on my own version of Syringe in order to enhance it's functions. I want to publish my work for the community and use the improved Syringe in CnCNet. The only thing that stops me from releasing my improvements is the used license.

Currently used CC-BY-NC-SA license:
a) is ill-suited for source code and programs because it wasn't written with them in mind but more with things like art assets, which can cause certain issues like written here;
b) does not provide copyleft level of protection from producing different closed-source incompatible versions of Syringe around the community, thus potentially creating extensions that rely on different incompatible versions of Syringe;
c) is not compatible with GNU (L)GPL

So, I want to ask the contributors to switch the license. I think best solution will be LGPL - it does provide the needed license protection while also not imposing any possible issues on extensions, while the API header file that is to be included in engine extensions that are using the Syringe should be licensed separately under any permissive license (or given into public domain or it's alternatives). For all API headers i want to use MIT.

@DCoderLT
Copy link
Member

DCoderLT commented Feb 17, 2024

Hi,

I have no objections to such a change.

cc’ing @AlexBx to make sure he sees this.
cc’ing @pdinklag — the original author of Syringe before it was published on GitHub.

(Edit: also cc’ing @EvilRenegade)

@AlexBx
Copy link
Member

AlexBx commented Feb 17, 2024

Hey,
no objections to a change either.

@EvilRenegade
Copy link
Member

EvilRenegade commented Feb 18, 2024

Is this the 20 Year RockPatch Reunion or something?

@DCoderLT Just to be in the loop or a specific reason?

Edit: I see, I pop up in the contributors list. If you click through, though, you will see that my only "contribution" was, ironically, adding the license file. After pestering pd and you to make it open source back then, and you chose Creative Commons.

So basically, my only contribution will be obliterated by this change. xD

@Metadorius
Copy link

Is this the 20 Year RockPatch Reunion or something?

I mean we (me for sure) won't mind such a turn of events, especially if Phobos devs are invited for the reunion. 😄

@DCoderLT
Copy link
Member

DCoderLT commented Feb 18, 2024

@DCoderLT Just to be in the loop or a specific reason?

@EvilRenegade “Just to keep you in the loop” is a good enough reason, especially when your Matrix client is so coughloopycough 😛

Is this the 20 Year RockPatch Reunion or something?

It probably is now, yeah 😄🥳

@pdinklag
Copy link

No objections to the proposed license changes!

Is this the 20 Year RockPatch Reunion or something?

It sure seems so!

This was referenced Feb 27, 2024
@Multfinite
Copy link
Contributor Author

Here.
#3

@EvilRenegade
Copy link
Member

Is the MIT secondary license even necessary? Isn't this covered by section 3 of the LGPL?

  1. Object Code Incorporating Material from Library Header Files.

The object code form of an Application may incorporate material from
a header file that is part of the Library. You may convey such object
code under terms of your choice, provided that, if the incorporated
material is not limited to numerical parameters, data structure
layouts and accessors, or small macros, inline functions and templates
(ten or fewer lines in length), you do both of the following:

a) Give prominent notice with each copy of the object code that the
Library is used in it and that the Library and its use are
covered by this License.

b) Accompany the object code with a copy of the GNU GPL and this license
document.

@Multfinite
Copy link
Contributor Author

Multfinite commented Mar 8, 2024

Is the MIT secondary license even necessary? Isn't this covered by section 3 of the LGPL?

  1. Object Code Incorporating Material from Library Header Files.

The object code form of an Application may incorporate material from
a header file that is part of the Library. You may convey such object
code under terms of your choice, provided that, if the incorporated
material is not limited to numerical parameters, data structure
layouts and accessors, or small macros, inline functions and templates
(ten or fewer lines in length), you do both of the following:
a) Give prominent notice with each copy of the object code that the
Library is used in it and that the Library and its use are
covered by this License.
b) Accompany the object code with a copy of the GNU GPL and this license
document.

I re-read this and asked some people and you're right.

I will change the PR for few days.

@Multfinite
Copy link
Contributor Author

I think now it should be nice.
@AlexBx @EvilRenegade @Metadorius check PR please.

@Multfinite
Copy link
Contributor Author

@AlexBx @EvilRenegade @DCoderLT @pdinklag
Can someone look at PR and confirm merging?

@EvilRenegade
Copy link
Member

This is something left to those who actually wrote the code being relicensed. 🤷‍♂️

@DCoderLT
Copy link
Member

Since we all already agreed to this change, I don’t think we need to wait for everyone to rubber-stamp the actual PR.
borrows Renegade’s bureaucrat hat

Merged! Good luck with your future developments :)

@DCoderLT DCoderLT linked a pull request Mar 22, 2024 that will close this issue
@Multfinite
Copy link
Contributor Author

Since we all already agreed to this change, I don’t think we need to wait for everyone to rubber-stamp the actual PR. borrows Renegade’s bureaucrat hat

Merged! Good luck with your future developments :)

Thanks! Now I need to polish up my current code and push it here. Now i am worked here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants