AP_Airspeed: don't send AIRSPEED_AUTOCAL message when disabled #28793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamPete1
reviewed
Dec 2, 2024
| the AIRSPEED_AUTOCAL message doesn't have an instance number | ||
| so we can only send it for one sensor at a time | ||
| */ | ||
| for (uint8_t i=0; i<AIRSPEED_MAX_SENSORS; i++) { |
There was a problem hiding this comment.
Should we send instances in turn? This doubles the bandwidth if you have two sensors.
There was a problem hiding this comment.
I just added a break, it doesn't have an instance number, so can't usefully send more than one
we were wasting bandwidth sending this all the time also fixed to support calibration messages for 2nd airspeed sensor
tridge
force-pushed
the
pr-airspeed-autocal-msg
branch
from
4f1f8ae to
2e75d79
Compare
IamPete1
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we were wasting bandwidth sending this all the time
also fixed to support calibration messages for 2nd airspeed sensor