Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ICacheMethod.FlushAsync to ICacheMethod.ClearAsync #31

Closed
Archomeda opened this issue Jan 25, 2020 · 1 comment
Closed

Rename ICacheMethod.FlushAsync to ICacheMethod.ClearAsync #31

Archomeda opened this issue Jan 25, 2020 · 1 comment
Labels
Area: Web cache Related to the web API caching Duration: Short Less than 2 hours of estimated work Priority: Low Low priority Resolution: Fixed The issue has been fixed

Comments

@Archomeda
Copy link
Owner

This is a badly named method that causes confusion, see #30.

Needs to be marked as deprecated in 0.8.0 and be fully renamed in 0.9.0+.
@Archomeda Archomeda added good first issue Good for newcomers Duration: Short Less than 2 hours of estimated work Area: Web cache Related to the web API caching labels Jan 25, 2020
Archomeda added a commit that referenced this issue Feb 20, 2020
@Archomeda
Deprecate ICacheMethod.FlushAsync in favor of ClearAsync #31
345d1dd
@Archomeda
Copy link
Owner Author

Deprecation is handled in #34. I'm keeping this issue open until v0.9.0 where FlushAsync will be fully removed in favor of ClearAsync.

@Archomeda Archomeda added Priority: Low Low priority Status: Ready Work is accepted and is planned for a future release and removed good first issue Good for newcomers labels Feb 20, 2020
@Archomeda Archomeda mentioned this issue Mar 20, 2020
Merged
@Archomeda Archomeda added Status: Waiting for release Work has finished and is waiting to be released and removed Status: Ready Work is accepted and is planned for a future release labels Mar 20, 2020
@Archomeda Archomeda added Resolution: Fixed The issue has been fixed and removed Status: Waiting for release Work has finished and is waiting to be released labels Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Web cache Related to the web API caching Duration: Short Less than 2 hours of estimated work Priority: Low Low priority Resolution: Fixed The issue has been fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Archomeda