Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.withoutCallback should always be stubbed in testing #21

Open
Pacane opened this issue Sep 25, 2015 · 1 comment
Open

.withoutCallback should always be stubbed in testing #21

Pacane opened this issue Sep 25, 2015 · 1 comment

Comments

@Pacane
Copy link

Pacane commented Sep 25, 2015

Should change DelegateMocking to this:

    public DelegateMocking<R> useResource(R resource) {
        assert this.resource == null
                : "useResource(R) called more than once. Did you forget to call DelegateTestUtils.init()?";

        this.resource = resource;
        callbackCaptor = ArgumentCaptor.forClass(AsyncCallback.class);
        delegatingDispatchRequestCaptor = ArgumentCaptor.forClass(DelegatingDispatchRequest.class);

        when(delegate.withCallback(callbackCaptor.capture())).thenReturn(resource);
        when(delegate.withoutCallback(callbackCaptor.capture())).thenReturn(resource);
        when(delegate.withDelegatingDispatchRequest(delegatingDispatchRequestCaptor.capture())).thenReturn(delegate);

        return this;
    }
@olafleur
Copy link
Member

olafleur commented Jan 4, 2016

@Pacane do you want to implement that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants