Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing override for GetSchemaTable #23

Open
MyrionsHub opened this issue Feb 18, 2021 · 4 comments
Open

missing override for GetSchemaTable #23

MyrionsHub opened this issue Feb 18, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@MyrionsHub
Copy link

Hi,

we are using DataTable.Load() which calls GetSchemaTable() at a later state. This is only implemented as a virtual method in System.Data.Common.DbDataReader and needs an override. Otherwise there will be a NotSupportedException.

System.NotSupportedException: Specified method is not supported.
   at System.Data.Common.DbDataReader.GetSchemaTable()

Would it be possible to implement this directly inside the package?
@dvoituron
Copy link
Contributor

I will check for a future version.

@dvoituron dvoituron added the enhancement New feature or request label Feb 23, 2021
@psyciknz
Copy link

psyciknz commented Mar 9, 2022

Did anything happen with this? I'm try to test a reader into a datatable as well, and getting the method is not supported error as well.

@dvoituron
Copy link
Contributor

I haven't had time to develop this yet.
Can you fork the project and submit a proposition of code?

javnov pushed a commit to javnov/DbMocker that referenced this issue Jul 1, 2022
Apps72#23 Implement GetSchemaTable method to allow load DataSet a…
ea9672f 
…nd/or `DataTable` using `IDataReader`
@javnov javnov mentioned this issue Jul 1, 2022
Merged
@javnov
Copy link
Contributor

javnov commented Jul 1, 2022

Hi @dvoituron,

I've just created this PR #31 to address this.

dvoituron pushed a commit that referenced this issue Jul 7, 2022
@javnov
#23 Implement GetSchemaTable method to allow load DataSet and/or …
2619b09 
…`DataTable` using `IDataReader` (#31)

Co-authored-by: nelsonn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@psyciknz @dvoituron @javnov @MyrionsHub