Processing Pattern Encoder: Set amount doesn't work if pick block is not the default of middle click

[coyo-t]

Describe the bug

If pick block is not set to middle click, you are unable to open the "Set Amount" screen in the processing pattern encoder. Middle click will do nothing, and your custom pick block key will just cause the item to dissapear.

How to reproduce the bug

Set pick block to ` for example (this is what I use), open a pattern encoding terminal for a processing pattern and attempt to set a specific amount of an item with either ` or middle click

Expected behavior

Either middle click opens the "Set Amount" screen (regardless of whether its your pick block key or not), or your pick block key does.

Additional details

This doesn't happen with requesting something to be crafted. using my pick block key of (`) on something that can be crafted has the dialog come up fine.

Both of these should probably be its own unique bind instead of piggybacking off of pick block, or let the user do shift+mousewheel to change the amount as well

Which minecraft version are you using?

1.21

On which mod loaders does it happen?

NeoForge

Crash log

https://pastebin.com/6ptsjDJq

[shartte]

We are not using the pick block binding for handling middle-mouse-clicks in the UI. So something else is actually forwarding that, maybe?

[Helios23]

@shartte Is there a keybind it should be using? In latest ATM9 I've unbound all middleclick binds but still have same issue, have also unbound all inv tweaks mod binds

[Mithi83]

https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/main/src/main/java/appeng/client/gui/me/items/PatternEncodingTermScreen.java#L99

Seems to be the relevant code here. This if (this.minecraft.options.keyPickItem.matchesMouse(btn)) sounds like it will only ever work if you have a keybind for pick block that is a mouse button.

[coyo-t]

https://github.com/AppliedEnergistics/Applied-Energistics-2/blob/main/src/main/java/appeng/client/gui/me/items/PatternEncodingTermScreen.java#L99

Seems to be the relevant code here. This if (this.minecraft.options.keyPickItem.matchesMouse(btn)) sounds like it will only ever work if you have a keybind for pick block that is a mouse button.

I just tested this by setting pick block to left mouse and yeah that makes the "set amount" screen come up