Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Pasting unformatted text in formatted text does not format #688

Open
jpenna opened this issue Jan 24, 2024 · 3 comments · May be fixed by #692
Open

[Bug] Pasting unformatted text in formatted text does not format #688

jpenna opened this issue Jan 24, 2024 · 3 comments · May be fixed by #692

Comments

@jpenna
Copy link
Contributor

jpenna commented Jan 24, 2024 •
edited
Loading

Bug Description

Pasting pastes with format even when there is none (default background, for example).

Pasting without format also changes the format at the destination.

How to Reproduce

  1. Add color to the background of a text
  2. Copy some text
  3. Paste it between the formatted text as unformatted text (ctrl+shift+v)
  4. See the pasted text does not have background

Expected Behavior

The copied text should be pasted keeping the format of the destination area when it is an unformatted text.

At least, using ctrl+shift+v should paste plain text and keep the destination format, but it doesn't.

Operating System

Linux

AppFlowy Editor Version(s)

Built from source

Screenshots

Screencast.from.24-01-2024.11.03.01.webm

Additional Context

No response
@LucasXu0
Copy link
Collaborator

@jpenna You were pasting the text without formatting, but you expected the text to follow the style of the destination text, correct?

@jpenna
Copy link
Contributor Author

jpenna commented Jan 24, 2024 via email

@jpenna
Copy link
Contributor Author

jpenna commented Jan 24, 2024

Sorry, I replied on the run and didn't realize it was another issue I've opened. I was working on another fix and not this one.

I'll work on this tomorrow.

@jpenna jpenna linked a pull request Jan 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use format of wrapping node when pasting plain text jpenna/appflowy-editor
2 participants
@LucasXu0 @jpenna