Fix url query generation when value is a list

Author: adamruzicka

apypie/api.py

@@ -39,6 +39,12 @@ def _qs_param(param):
     return param
 
 
+def _qs_key(k, v):
+    if isinstance(v, (list, tuple)):
+        return f"{k}[]"
+    return k
+
+
 class Api(object):
     """
     Apipie API bindings
@@ -305,7 +311,7 @@ def http_call(self, http_method, path, params=None, headers=None, data=None, fil
 
         if params:
             if http_method in ['get', 'head']:
-                kwargs['params'] = {k: _qs_param(v) for k, v in params.items()}
+                kwargs['params'] = {_qs_key(k, v): _qs_param(v) for k, v in params.items()}
             else:
                 kwargs['json'] = params
         elif http_method in ['post', 'put', 'patch'] and not data and not files:

tests/test_apypie.py

@@ -240,6 +240,16 @@ def test_http_call_get_with_params(api, requests_mock):
     api.http_call('get', '/', {'test': 'all the things'})
 
 
+def test_http_call_get_with_list_params(api, requests_mock):
+    requests_mock.get('https://api.example.com/?test[]=all&test[]=the&test[]=list', text='{}')
+    api.http_call('get', '/', {'test': ['all', 'the', 'list']})
+
+
+def test_http_call_get_with_tuple_params(api, requests_mock):
+    requests_mock.get('https://api.example.com/?test[]=all&test[]=the&test[]=tuple', text='{}')
+    api.http_call('get', '/', {'test': ('all', 'the', 'tuple')})
+
+
 def test_http_call_post(api, requests_mock):
     expected_headers = {
         'Accept': 'application/json;version=1',