fix: Deltoid wrapping #115
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 16, 2025 12:52
…ence (model does not load)
…(model does not load)
added 15 commits
August 20, 2025 11:51
…' into DeltoidWrapping
Member
|
@Hamedshayestehpour, The large arm refactoring/inertia work made by @toerholm has been merged, so you may need to update this PR. |
added 3 commits
October 23, 2025 13:05
Anterior: on cyl moving with clavicula and gh joint. Have stop cylinders represent the lateral deltoid. Lateral: on ellipsoids like the previous new versions Posterior: on cyl moving with scapula and gh joint. Have stop cylinders represent the lateral deltoid. All have humerus cyl, to wrapp on and create rotational moment in humerus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New ellipsoids were defined based on the nodes on the segments instead of fixed angles so it can scale properly.
Constraints were redefined to use nodes on the segments instead of rotational rhythms, improved when scaled and even on unscaled wrapping.
A cylinder were defined on the humerus which allow the deltoids to be able to make their functions as external and interal rotation of the humerus
Overall, the wrapping is improved and in the ROM with no penetrations, which happened in some postures before.