Skip to content

Commit 2b77593

Browse files
committed
refactor: Replace depracated QRegExp with QRegularExpression
1 parent d20f9be commit 2b77593

File tree

5 files changed

+15
-20
lines changed

5 files changed

+15
-20
lines changed

src/common.cpp

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@
2424
#include <QDirIterator>
2525
#include <QLibraryInfo>
2626
#include <QReadWriteLock>
27-
#include <QRegExp>
27+
#include <QRegularExpression>
28+
2829
#ifdef Q_OS_WIN
2930
#include <QStandardPaths>
3031
#endif
@@ -89,11 +90,8 @@ QStringList arguments(const int &argc, char **argv)
8990
QStringList parseArgumentsString(QString tempString)
9091
{
9192
bool inside = (!tempString.isEmpty() && tempString.at(0) == QChar('"'));
92-
#if QT_VERSION >= QT_VERSION_CHECK(5, 15, 0)
93-
QStringList tempList = tempString.split(QRegExp("\""), Qt::SkipEmptyParts);
94-
#else
95-
QStringList tempList = tempString.split(QRegExp("\""), QString::SkipEmptyParts);
96-
#endif
93+
QStringList tempList = tempString.split(QRegularExpression("\""), Qt::SkipEmptyParts);
94+
9795
QStringList finalList = QStringList();
9896
QStringListIterator iter(tempList);
9997

@@ -104,11 +102,8 @@ QStringList parseArgumentsString(QString tempString)
104102
if (inside)
105103
finalList.append(temp);
106104
else
107-
#if QT_VERSION >= QT_VERSION_CHECK(5, 15, 0)
108-
finalList.append(temp.split(QRegExp("\\s+"), Qt::SkipEmptyParts));
109-
#else
110-
finalList.append(temp.split(QRegExp("\\s+"), QString::SkipEmptyParts));
111-
#endif
105+
finalList.append(temp.split(QRegularExpression("\\s+"), Qt::SkipEmptyParts));
106+
112107
inside = !inside;
113108
}
114109

@@ -179,7 +174,7 @@ QIcon loadIcon(QString name)
179174
QDirIterator it(":images/", QDirIterator::Subdirectories);
180175
QString fallback_location = "";
181176
// search also for variants with underscore like document_save.png for document-save
182-
QRegExp regex = QRegExp(".*" + name.replace(QChar('-'), "[_-]") + "\\.(svg|png)");
177+
QRegularExpression regex = QRegularExpression(".*" + name.replace(QChar('-'), "[_-]") + "\\.(svg|png)");
183178
while (it.hasNext())
184179
{
185180
QString value = it.next();

src/gamecontroller/gamecontroller.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
#include <cmath>
3131

3232
#include <QDebug>
33-
#include <QRegExp>
33+
#include <QRegularExpression>
3434
#include <QXmlStreamReader>
3535
#include <QXmlStreamWriter>
3636

@@ -91,7 +91,7 @@ QString GameController::getSerialString() const
9191
if (controller != nullptr)
9292
{
9393
const char *serial = SDL_GameControllerGetSerial(controller);
94-
temp = QString(serial).remove(QRegExp("[^A-Za-z0-9]"));
94+
temp = QString(serial).remove(QRegularExpression("[^A-Za-z0-9]"));
9595
}
9696
#endif
9797
return temp;

src/globalvariables.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,8 @@ const int GlobalVariables::InputDevice::RAISEDDEADZONE = 20000;
101101
const int GlobalVariables::InputDevice::DEFAULTKEYREPEATDELAY = 660; // 660 ms
102102
const int GlobalVariables::InputDevice::DEFAULTKEYREPEATRATE = 40; // 40 ms. 25 times per second
103103

104-
// QRegExp GlobalVariables::InputDevice::emptyGUID("^[0]+$");
105-
QRegExp GlobalVariables::InputDevice::emptyUniqueID("^[0]+$");
104+
// QRegularExpression GlobalVariables::InputDevice::emptyGUID("^[0]+$");
105+
QRegularExpression GlobalVariables::InputDevice::emptyUniqueID("^[0]+$");
106106

107107
// ---- JOYAXIS ---- //
108108

src/globalvariables.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
#include <QList>
2323
#include <QObject>
24-
#include <QRegExp>
24+
#include <QRegularExpression>
2525

2626
namespace GlobalVariables {
2727
class JoyButton
@@ -107,8 +107,8 @@ class InputDevice
107107
static const int DEFAULTKEYREPEATDELAY;
108108
static const int DEFAULTKEYREPEATRATE;
109109

110-
// static QRegExp emptyGUID;
111-
static QRegExp emptyUniqueID;
110+
// static QRegularExpression emptyGUID;
111+
static QRegularExpression emptyUniqueID;
112112
};
113113

114114
class JoyAxis

src/joystick.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ QString Joystick::getSerialString() const
112112
if (m_joyhandle != nullptr)
113113
{
114114
const char *serial = SDL_JoystickGetSerial(m_joyhandle);
115-
temp = QString(serial).remove(QRegExp("[^A-Za-z0-9]"));
115+
temp = QString(serial).remove(QRegularExpression("[^A-Za-z0-9]"));
116116
}
117117
#endif
118118

0 commit comments

Comments
 (0)