fix: Problems with legacy windows char conversions

Author: pktiuk

src/winextras.cpp

@@ -270,8 +270,6 @@ QString WinExtras::getForegroundWindowExePath()
     if (windowProcess != NULL)
     {
         WCHAR filename[MAX_PATH];
-        TCHAR filename_xp[MAX_PATH];
-        // qDebug() << QString::number(sizeof(filename)/sizeof(TCHAR));
         if (pQueryFullProcessImageNameW)
         {
             // Windows Vista and later
@@ -283,12 +281,8 @@ QString WinExtras::getForegroundWindowExePath()
             exePath = QString::fromWCharArray(filename);
         } else
         {
-            // Windows XP
-            memset(filename_xp, 0, sizeof(filename_xp));
-            GetModuleFileNameEx(windowProcess, NULL, filename_xp, MAX_PATH * sizeof(TCHAR));
-            exePath = QString(filename_xp);
+            qWarning() << "Windows XP is not supported";
         }
-
         CloseHandle(windowProcess);
     }
 
@@ -360,8 +354,12 @@ bool WinExtras::elevateAntiMicro()
     char *tempfile = ba.data();
     tempverb[5] = '\0';
     tempfile[antiProgramLocation.length()] = '\0';
-    sei.lpVerb = tempverb;
-    sei.lpFile = tempfile;
+    wchar_t lpVerb[20];
+    wchar_t lpFile[MAX_PATH];
+    mbstowcs(lpVerb, tempverb, strlen(tempverb) + 1); // Plus null
+    mbstowcs(lpFile, tempfile, strlen(tempfile) + 1); // Plus null
+    sei.lpVerb = lpVerb;
+    sei.lpFile = lpFile;
     sei.hwnd = NULL;
     sei.nShow = SW_NORMAL;
     BOOL result = ShellExecuteEx(&sei);