Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete interface for validate in NgxLinkifyOptions #117

Open
teolag opened this issue Oct 28, 2019 · 1 comment
Open

Incomplete interface for validate in NgxLinkifyOptions #117

teolag opened this issue Oct 28, 2019 · 1 comment

Comments

@teolag
Copy link

teolag commented Oct 28, 2019

The interface for validate in NgxLinkifyOptions is incomplete.

According to linkifyjs the validate attribute could be a boolean, function or an object
https://soapbox.github.io/linkifyjs/docs/options.html#validate

When I set validate to a function the linter typescript warns me I'm using the wrong type.
If I set the function as any, everything works fine. So the code accepts an function but the interface does not

@AnthonyNahas
Copy link
Owner

I would appreciate a PR from you🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants