Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for showing images over enum types #3

Open
ThrashAbaddon opened this issue Nov 15, 2022 · 4 comments
Open

Support for showing images over enum types #3

ThrashAbaddon opened this issue Nov 15, 2022 · 4 comments

Comments

@ThrashAbaddon
Copy link

Hi, I've noticed there isn't a support for enums. This item is an enhancement request to introduce support for enum types.

@Andlon
Copy link
Owner

Andlon commented Dec 8, 2022

PRs welcome! I'm pretty thinly stretched right now and this crate is unfortunately pretty low on my list of priorities.

@drdozer
Copy link

drdozer commented Jan 13, 2023

This is something I'd also love to have. Is it a fairly mechanical change to the existing code, or do I need to know stuff to implement it?

@drdozer
Copy link

drdozer commented Jan 13, 2023

I've had a quick peak at the code, but am not sure quite what to do. The error I get when trying to add images to an enum variant is:

error: expected non-macro attribute, found attribute macro `embed_doc_image`
  --> src/e2.rs:41:7
   |
41 |     #[embed_doc_image("edge-image", "data/edge_images/0.png")]
   |       ^^^^^^^^^^^^^^^ not a non-macro attribute

I'm guessing this error is actually coming from rustc rather than from your macro? So I'm not quite sure which tyres to kick to get it to work properly.

@Andlon
Copy link
Owner

Andlon commented Feb 2, 2023

Hi @drdozer, thanks for looking into this. I'm ... not sure what's going on here. I must admit I don't have much experience writing proc macros beyond what I've done for this crate. Unfortunately I also have very limited time at the moment and can't devote much time to this crate. I'd be happy to try to assist, but I think you'd have to do most of the legwork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants