Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

Roles menu should stay visible when changing value of a role #176

Closed
LiWeiYeh opened this issue Feb 21, 2023 · 1 comment
Closed

Roles menu should stay visible when changing value of a role #176

LiWeiYeh opened this issue Feb 21, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@LiWeiYeh
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Relates to #147. The roles menu in the navbar should not close when you change the value of a role.

Describe the solution you'd like
When clicking on the roles icon in the navbar, it shows the roles and the values (true/false) relating to that role. When changing the role, the menu instantly closes. However, the desired implementation should keep the roles menu open.

Describe alternatives you've considered
Doing this was hard, because we're using primeng as a library, in this case specifically the menu. The primeng menu does not have a method to keep it visible. (Although, there is a visible field of the menu, we cannot directly call it).

Additional context

@LiWeiYeh LiWeiYeh added the enhancement New feature or request label Feb 21, 2023
@Michiel-s
Copy link
Member

As discussed last Friday during sprint review, this issue/feature is not needed anymore. It's fine to close the menu when a role is (de)activated

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants