Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources: Added resources in navbar #211

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tannuiscoding
Copy link

Closes #191

here is the screenshot of the fixed navbar.

Changes

  • added resources page
  • added the logo with main menu to make it user friendly
  • here is the screenshot

Screenshot 2024-11-01 194528

@Amna-Hassan04
Copy link
Owner

@tannuiscoding the navbar shouldnt have like this light black ground and "main menu" heading. and the about & feedback heading should be in one row line.
image

@zoobiasyed
Copy link
Collaborator

@tannuiscoding kindly work on the improving of navbar. Amna will merge it as soon as you deliver the improved product.

Copy link
Collaborator

@zoobiasyed zoobiasyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the navbar should have the same colour all over, not to mention that the alignment should be improved.

@zoobiasyed
Copy link
Collaborator

@tannuiscoding your pr will only be merged if all the relevant details and pictures are mentioned. Also all the test cases should be passed, before the deadline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Cant See the Resources page in the Navbar
3 participants