Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve treatment of nested links #442

Closed
pkra opened this issue Apr 24, 2024 · 4 comments
Closed

improve treatment of nested links #442

pkra opened this issue Apr 24, 2024 · 4 comments

Comments

@pkra
Copy link
Member

pkra commented Apr 24, 2024

While AmerMathSoc/texml#198 could help a lot, we could still do a better job here -- either more like HTML parsing or by stripping inner links.

@pkra pkra changed the title improve unnest.js unnest.js: improve unnestLinks() Apr 24, 2024
@pkra
Copy link
Member Author

pkra commented Apr 24, 2024

I guess this relates to #430

@pkra pkra self-assigned this Apr 24, 2024
@pkra pkra added this to the 2024 milestone Apr 24, 2024
@pkra
Copy link
Member Author

pkra commented Apr 29, 2024

Following the F2F for AmerMathSoc/texml#198, it's more consistent to "flatten" nested links and emit a warning (since we can assume that texml will prevent them, too).

@pkra
Copy link
Member Author

pkra commented Apr 29, 2024

This will formally be a breaking change. (Thought it should not have any noticeable side effects.)

@pkra
Copy link
Member Author

pkra commented Apr 29, 2024

I'm leaning towards removing unnest.js entirely and taking the reverse approach, i.e., check the output for .closest('a') and respond.

That will simplify xref (which has a special case for toc-entry//xref from the earliest days because toc-entry generates a link).

@pkra pkra changed the title unnest.js: improve unnestLinks() improve treatment of nested links Apr 29, 2024
@pkra pkra closed this as completed in cdc63a9 Apr 29, 2024
pkra added a commit that referenced this issue Apr 29, 2024
Leftover from #442.
No tests for warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant