Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Typo] 34. ERC721 问题 #672

Open
XdpCs opened this issue Mar 12, 2024 · 2 comments
Open

[Typo] 34. ERC721 问题 #672

XdpCs opened this issue Mar 12, 2024 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@XdpCs
Copy link
Collaborator

XdpCs commented Mar 12, 2024

image

就是 这个词语感觉 缺少准确性
erc165 是 检测智能合约实现了哪些接口
@XdpCs
Copy link
Collaborator Author

XdpCs commented Mar 13, 2024

OpenZeppelin 的 erc721 没有按照eip721 来使用payable 修饰safeTransferFrom, transferFrom, and approve 方法
看了OpenZeppelin的issue解释是 怕用户误转ether进来
造成不可恢复的错误

我们的教程 是按照标准的eip721实现 还是 按照OpenZeppelin （目前是按照OpenZeppelin实现的）

@XdpCs
Copy link
Collaborator Author

XdpCs commented Mar 13, 2024 •
edited
Loading

OpenZeppelin 的 讨论链接：OpenZeppelin/openzeppelin-contracts#1015

@XdpCs XdpCs closed this as completed Nov 3, 2024
@XdpCs XdpCs reopened this Nov 3, 2024
@XdpCs XdpCs added the documentation Improvements or additions to documentation label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@XdpCs