Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azblob: replace deprecated and unsupported libraries for interaction with Azure #1047

Open
dnovvak opened this issue Nov 22, 2024 · 1 comment
Milestone

Comments

@dnovvak
Copy link

dnovvak commented Nov 22, 2024

clickhouse-backup has built in support for azure managed identities (AZBLOB_USE_MANAGED_IDENTITY option).

Unfortunately it seems limited to single use case - system assigned identity on azure VM. azblob.go#L105 uses NewServicePrincipalTokenFromMSI function:

NewServicePrincipalTokenFromMSI creates a ServicePrincipalToken via the MSI VM Extension. It will use the system assigned identity when creating the token. msiEndpoint - empty string, or pass a non-empty string to override the default value. Deprecated: use NewServicePrincipalTokenFromManagedIdentity() instead.

My use case is to utilize clickhouse-backup with convenient Entra Workload ID for Azure Kubernetes Service as it is a kind of Managed Identity authentication too.

I suppose that using the recommended azidentity lib would cover all the authentication methods supported by azure.


adal deprecation notice:

NOTE: This module will go out of support by March 31, 2023. For authenticating with Azure AD, use module azidentity instead. For help migrating from adal to azidentiy please consult the migration guide. General information about the retirement of this and other legacy modules can be found here.


By the way it would be worth to update the over two years outdated azure-storage-blob-go ([go.mod#L6])(https://github.com/Altinity/clickhouse-backup/blob/master/go.mod#L6) with new azure-storage-blob-go.

@Slach
Copy link
Collaborator

Slach commented Nov 23, 2024

@dnovvak feel free to make PR

@Slach Slach added this to the 2.7.0 milestone Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants