Clean replication and distributed_ddl queues method #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filimonov
reviewed
Jun 3, 2024
| - ensure that detached_parts are empty, detach partition, then attach it back (on sinlge replica!), then remove leftovers from detached_parts | ||
| - detach the tables, remove the merge from the queue, attach tables back | ||
|
|
||
| Check: https://github.com/Altinity/support-team/blob/main/common_issues/ImpossibleMergeInQueue.md |
filimonov
reviewed
Jun 3, 2024
| - try to SYSTEM RESTART REPLICA | ||
| - try to restart ClickHouse | ||
|
|
||
| ## don't run things below blindly!!! they are dangerous! you can make it worse! Only if you clearly understand the problem and what that solution will do. |
There was a problem hiding this comment.
I'm a bit afraid of publishing that because of that... It can be harmful, and fixing the ClickHouse after unsuccessful attempts of fixing that is more cumbersome, and data can be damaged.
There was a problem hiding this comment.
Yes agree i can delete it and rephrase. This also is a WIP, need to add a section for cleaning the distributed_ddl_queue that I will probably need to write it with care. I'll fix many stuff in next commit
|
@filimonov @BorisTyshkevich @SaltTan @UnamedRus @realyota what do you think? is it very detailed/problematic? |
|
I agree with Micha that it's a very dangerous path, and we don't need to
announce such a trick to the public. But for internal usage such collection
is quite useful. Place the recommendation on the Notion page.
…On Fri, Jun 7, 2024 at 11:00 AM Diego Nieto ***@***.***> wrote:
@filimonov <https://github.com/filimonov> @BorisTyshkevich
<https://github.com/BorisTyshkevich> @SaltTan <https://github.com/SaltTan>
@UnamedRus <https://github.com/UnamedRus> @realyota
<https://github.com/realyota> what do you think? is it very
detailed/problematic?
—
Reply to this email directly, view it on GitHub
<#83 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A56I4CRI72C4QQ26NQCJNDDZGFZCPAVCNFSM6AAAAABISTSRMSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJUGQYDIMJYG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
delete the dangerous stuff (agree) and added the task_ddl_queue cleanup but again is ZK manual intervention which is something dangerous too. I'll try to rewrite |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have read the CLA Document and I hereby sign the CLA