Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the messaging for installing dbt #1281

Closed
1 task
anandgupta42 opened this issue Jul 5, 2024 · 9 comments
Closed
1 task

Improve the messaging for installing dbt #1281

anandgupta42 opened this issue Jul 5, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@anandgupta42
Copy link
Contributor

Describe the feature

When dbt is unavailable, we offer the user the option to install dbt. Sometimes, the user may have dbt installed but not in the Python environment selected for the extension. It would be helpful to inform the user of the Python path where dbt is located or provide a link to the FAQ page explaining the error in detail.

Screenshot 2024-07-05 at 1 15 33 PM

Describe alternatives you've considered

No response

Who will benefit?

Mostly the users who are setting up the extension for the first time.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@anandgupta42 anandgupta42 added the enhancement New feature or request label Jul 5, 2024
@OneCyrus
Copy link

please add a setting to disable this message completely. see #854

i see so many people wasting time with this message just because the extension has a timing issue.

@anandgupta42
Copy link
Contributor Author

@OneCyrus Can you clarify what do you mean by "the extension has a timing issue." ?

@anandgupta42
Copy link
Contributor Author

The issue is that the user does not have dbt installed in the selected Python environment. So, technically the message is right.

@OneCyrus
Copy link

but in our case only for a few seconds. so the people try to troubleshoot the environment even though dbt is already installed.

@mdesmet
Copy link
Contributor

mdesmet commented Jul 12, 2024

Could you elaborate on your environment because it should not give any false alarm on dbt installed. Are you using vscode locally or on codespaces?

Every time the python interpreter is selected, the dbt installation is verified. Are you changing the python interpreter?

@OneCyrus
Copy link

OneCyrus commented Aug 6, 2024

@mdesmet we are using devcontainers (codespaces and locally).

the configuration is like below. after the devcontainer is built vscode automatically installs the dbt extension and also installs the dbt python module through the "postCreateCommand" in parallel. basically the dbt extension usually starts before the dbt python module is installed which leads to the missing dbt error. but a few seconds later dbt is then installed but most users already clicked on the dbt install button.

"postCreateCommand": "bash ${containerWorkspaceFolder}/init.sh",
"customizations": {
  "vscode": {
    "extensions": [
      "innoverio.vscode-dbt-power-user",
      ....
    ]
  }
}

@OneCyrus
Copy link

@mdesmet it should be pretty easy fix to just add an option to hide the "please ensure dbt is installed" dialog as a config setting.

@mdesmet
Copy link
Contributor

mdesmet commented Aug 24, 2024

Why are you not installing dbt in your devcontainer image itself? it will boot up your environment faster that way and dbt will immediately detected.

@mdesmet
Copy link
Contributor

mdesmet commented Sep 17, 2024

@OneCyrus : Please reopen if above solution is not working for you.

@mdesmet mdesmet closed this as completed Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants