Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation editor adds tests to yml #1268

Closed
1 task
smitsrr opened this issue Jul 3, 2024 · 2 comments
Closed
1 task

Documentation editor adds tests to yml #1268

smitsrr opened this issue Jul 3, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@smitsrr
Copy link

smitsrr commented Jul 3, 2024

Expected behavior

We converted our ymls to use the new data_tests: syntax that is expected in dbt 1.8, however, when running and saving documentation via the extension it re-adds the tests using the old syntax, which I must then remove.

Actual behavior

What is added to the documentation .yml file:

columns:
      - name: sfdc_user_id
        description: The unique identifier of the SFDC user
        data_tests:
          - not_null:
              severity: error
          - unique:
              severity: error
        data_type: varchar
        tests:
          - not_null
          - unique

Steps To Reproduce

go to model
click documentation editor
click 'sync with database'
click 'save'

Log output/Screenshots

No response

Operating System

mac

dbt version

1.8.3

dbt Adapter

snowflake

dbt Power User version

Published 2020-08-18, 23:09:28 Last released 2024-06-26, 20:37:24 Last updated 2024-07-03, 11:25:38

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@smitsrr smitsrr added the bug Something isn't working label Jul 3, 2024
@anandgupta42
Copy link
Contributor

We will pick it up soon @smitsrr .

@anandgupta42
Copy link
Contributor

@smitsrr, a fix was released in version 0.42.0. Could you please confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants