Rules for pull request? #293
ip6li
started this conversation in
Show and tell
Replies: 1 comment 1 reply
-
|
Minimum: Should be formatted correctly, Java could should have Junit tests. |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
Thank you for fast reply. Regarding unit tests I have to implement TestContainers to test my new DataSource class with Hashicorp Vault. Test must configure Hashicorp Vault by script to provide MySQL credential rotation. |
Beta Was this translation helpful? Give feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Are there any rules regarding code quality, tests etc. for pull requests?
Beta Was this translation helpful? Give feedback.
All reactions