Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug almost fixed in v2.0.4] zpm console lag #156

Open
C4PTRAMPAGE opened this issue May 8, 2020 · 18 comments
Open

[bug almost fixed in v2.0.4] zpm console lag #156

C4PTRAMPAGE opened this issue May 8, 2020 · 18 comments

Comments

@C4PTRAMPAGE
Copy link

after some testing the bug #135 IS completely gone... if the console is placed facing east or west. however if placed on top of a solid block so it faces north or south the freezes still happen.

@C4PTRAMPAGE C4PTRAMPAGE changed the title [almost fixed in v2.0.4] zpm console lag [bug almost fixed in v2.0.4] zpm console lag May 8, 2020
@Dockter
Copy link
Member

Dockter commented May 8, 2020

That literally doesn't make sense. This being said, can you attach some picture to this ticket with the F3 diag screen up as well. This should help give me some context to this very strange issue.

@C4PTRAMPAGE
Copy link
Author

C4PTRAMPAGE commented May 9, 2020

yeah well its whats happening, and i can do 60 fps better than a picture https://youtu.be/0m7tzNbjKbE

@Bysokar
Copy link

Bysokar commented Jul 4, 2020

+1 this for players on stargatemc.com :(

@Bysokar
Copy link

Bysokar commented Jul 20, 2020

@Dockter The model is faulty. I just re-imported it into Crayfish's updated editor and 'optomised it' and it found errors with some of the values.

Reimport and recompile and it works beautifully.

@Dockter
Copy link
Member

Dockter commented Jul 20, 2020

Can you give me the model it created?

@Bysokar
Copy link

Bysokar commented Jul 21, 2020

zpm_console.zip

@Dockter Here you go. Note the reduction in filesize to start... but it also threw a bunch of errors about model verticies not being a multiple of 16.

Works a charm for me now.

@Dockter
Copy link
Member

Dockter commented Jul 22, 2020

I am testing this internally.

@Dockter
Copy link
Member

Dockter commented Jul 22, 2020

@draksterau my @wifee wants to know what version of model editors you're using. She said she used crayfish editor to do the original model so she's confused as to why it would have suddenly generated errors.

Dockter added a commit that referenced this issue Jul 22, 2020
@Bysokar
Copy link

Bysokar commented Jul 22, 2020

mc-0.7.0 :)

I imported json, then exported. Boom problem solved.

When I imported it said there were verticies that didn't have a multiple of 16. When I exported I selected optimize model.
Sorry I don't really know what im doing regarding this... but I do know it worked, hence mentioning.

@Dockter Also, I've implemented Universe gates in the StargateMC.com build of SGCraft for 1.12. You'd be welcome to the textures and sounds if you want to implement it. Code too...

@Dockter
Copy link
Member

Dockter commented Jul 22, 2020

Can you point me to the repo?

@Dockter
Copy link
Member

Dockter commented Jul 22, 2020

FYI, my wife reported that the .zip file you linked is missing the particle affect in the model.

@Bysokar
Copy link

Bysokar commented Jul 22, 2020

@Dockter https://github.com/stargatemc/sgcraft-1.12.2
Particle effect? Maybe that was what was lagging it?

@Bysokar
Copy link

Bysokar commented Jul 22, 2020

@Dockter Also, apologies in advance if the code is a mess and for my commit comments. Im self taught java & I've been doing things solo and didn't really need to bother with them :)

@Dockter
Copy link
Member

Dockter commented Jul 22, 2020

Is that repo hidden? I can't see it via the above link.

@Bysokar
Copy link

Bysokar commented Jul 22, 2020

@Dockter your invited as a collaborator (before you sent that message)… try visiting https://github.com/stargatemc
Yes its hidden. Our modifications are mostly for it to integrate with our coremod/advanced rocketry.
Please don't share it :)

@Dockter
Copy link
Member

Dockter commented Jul 23, 2020

I did not get an invite, I still cannot see that repo.

@Bysokar
Copy link

Bysokar commented Jul 23, 2020

image
Deleted and re-added the invite..... Maybe the link is case sensitive?

@C4PTRAMPAGE
Copy link
Author

can confirm that the 2.0.5 update seems to completely fix the lag problem, haven't done as much testing as i could though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants