From 5672a317acbdad147d4b0005e1d52807bcb86a47 Mon Sep 17 00:00:00 2001 From: Graham Neubig Date: Sun, 1 Dec 2024 12:45:54 -0500 Subject: [PATCH] fix: Update frontend workflows to catch TypeScript errors (#5347) Co-authored-by: openhands --- .github/workflows/fe-unit-tests.yml | 3 +++ .github/workflows/lint.yml | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/fe-unit-tests.yml b/.github/workflows/fe-unit-tests.yml index 2bced7406e6c..b720bfe34c28 100644 --- a/.github/workflows/fe-unit-tests.yml +++ b/.github/workflows/fe-unit-tests.yml @@ -35,6 +35,9 @@ jobs: - name: Install dependencies working-directory: ./frontend run: npm ci + - name: Run TypeScript compilation + working-directory: ./frontend + run: npm run make-i18n && tsc - name: Run tests and collect coverage working-directory: ./frontend run: npm run test:coverage diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index b6a9d327d860..1bfc8c91c6a4 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -30,10 +30,11 @@ jobs: run: | cd frontend npm install --frozen-lockfile - - name: Lint + - name: Lint and TypeScript compilation run: | cd frontend npm run lint + npm run make-i18n && tsc # Run lint on the python code lint-python: