Drop emoji support in CartographyIcon

This appears to be causing too many issues for clients to properly
decode, so the icons are now limited to just semantic tokens.

Author: alicerunsonfedora

Sources/MCMap/Library/CartographyIcon.swift

@@ -8,7 +8,7 @@
 import Foundation
 
 /// An enumeration of custom icons that can be used in a `.mcmap` package.
-public enum CartographyIcon: RawRepresentable, SendableCoded {
+public enum CartographyIcon: String, SendableCoded {
     /// The default or generic icon.
     ///
     /// This icon might be represented differently depending on the context it's used in. For example, this might
@@ -29,54 +29,4 @@ public enum CartographyIcon: RawRepresentable, SendableCoded {
 
     /// An icon that displays bubbles surrounded by sparkles.
     case sparklyBubbles
-
-    /// An icon that displays a single emoji character.
-    ///
-    /// > Important: When creating an icon from ``init(rawValue:)``, strings that don't contain emojis or only contain
-    /// > partial emojis are discounted.
-    case emoji(String)
-
-    public init?(rawValue: String) {
-        switch rawValue {
-        case "default":
-            self = .default
-        case "home":
-            self = .home
-        case "building":
-            self = .building
-        case "sparklyBubbles":
-            self = .sparklyBubbles
-        case "town":
-            self = .town
-        case "book":
-            self = .book
-        case rawValue where rawValue.isEmoji:
-            self = .emoji(rawValue)
-        default:
-            return nil
-        }
-    }
-
-    public var rawValue: String {
-        switch self {
-        case .default: "default"
-        case .home: "home"
-        case .building: "building"
-        case .sparklyBubbles: "sparklyBubbles"
-        case .town: "town"
-        case .book: "book"
-        case .emoji(let emojiString): emojiString
-        }
-    }
-}
-
-extension String {
-    var isEmoji: Bool {
-        unicodeScalars.allSatisfy { scalar in
-            scalar.properties.isEmoji
-                || scalar.properties.isEmojiModifier
-                || scalar.properties.isEmojiPresentation
-                || scalar.properties.isEmojiModifierBase
-        }
-    }
 }

Tests/MCMapTests/CartographyIconTests.swift

@@ -15,18 +15,12 @@ struct CartographyIconTests {
         let defaultIcon = CartographyIcon(rawValue: "default")
         #expect(defaultIcon == .default)
 
-        let emojiIcon = CartographyIcon(rawValue: "🚗")
-        #expect(emojiIcon == .emoji("🚗"))
-
         let noIcon = CartographyIcon(rawValue: "foo")
         #expect(noIcon == nil)
     }
 
     @Test func decodeToRawValue() async throws {
         let defaultIcon = CartographyIcon.default
         #expect(defaultIcon.rawValue == "default")
-
-        let emojiIcon = CartographyIcon.emoji("🚗")
-        #expect(emojiIcon.rawValue == "🚗")
     }
 }