Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Comment Section is not working properly #250

Open
3 tasks done
Saurabhchaudhary9799 opened this issue Oct 17, 2024 · 18 comments
Open
3 tasks done

BUG: Comment Section is not working properly #250

Saurabhchaudhary9799 opened this issue Oct 17, 2024 · 18 comments
Assignees
Labels
bug Something isn't working

Comments

@Saurabhchaudhary9799
Copy link
Contributor

Saurabhchaudhary9799 commented Oct 17, 2024

Is there an existing issue raised for this?

  • I have searched the existing issues

Describe your issue

When I comment any recipe , it shows comment when we remain on that page , but when we refresh page , it doesn't shows any comment that are done previous . the comments are not being either stored in database or fetched properly from database.

screen recording of issue

Screencast.from.2024-10-17.16-36-24.webm

Steps to reproduce

  1. go to recipe page
  2. click on any recipe
  3. do comment on that recipe
  4. refresh page
  5. see error

What was the expected result?

the expected functionality is that when we comment on any recipe , it should be display on that recipe page for everyone who is logged in after refreshing the page.

Proposed solution

This can be implemented by optimizing the relationship between the schemas with populate and by making an appropriate REST api for comments.

Would you like to work on this issue?

None

Terms & Conditions

  • I agree to follow the Code of Conduct
  • I'm a GSSOC'24 Ext contributor
@Saurabhchaudhary9799 Saurabhchaudhary9799 added the bug Something isn't working label Oct 17, 2024
@github-actions github-actions bot added gssoc-ext For GSSOC Extended Contribution. hacktoberfest-accepted labels Oct 17, 2024
Copy link

👋 Thank you @Saurabhchaudhary9799 for raising an issue! We appreciate your effort in helping us improve. Our team will review it shortly. Stay tuned!

@AlfiyaSiddique
Copy link
Owner

@Saurabhchaudhary9799 you are correct!
Please fix this, I am not sure if this feature is even implemented properly or not.
So please check if the backend storage for comments is there or not, if not please implement it.
Test the following cases after implementation:

  1. Comments stay event after refreshing.
  2. Other user's comments are visible to another account user.

@Saurabhchaudhary9799
Copy link
Contributor Author

@AlfiyaSiddique , Please add level3 label

@AlfiyaSiddique
Copy link
Owner

@Saurabhchaudhary9799 Level 3 is added when a feature is implemented from scratch and I think level 2 is fair for the PR.
Also, issue does not need a Level label it is counted from the PR

@AlfiyaSiddique
Copy link
Owner

One more thing, the comments are not visible on the deployed link after merging:
https://delightful-daifuku-a9f6ea.netlify.app/

image
can you check once

@Saurabhchaudhary9799
Copy link
Contributor Author

@AlfiyaSiddique , comment are perfectly working on local machine . But i will check this issue for sure.

@AlfiyaSiddique
Copy link
Owner

Yeah please check it once as it is not working on deployed

@AlfiyaSiddique
Copy link
Owner

I have explored it a bit and found the following behavior.
Certain comments are visible to the logged-in account user but when the logged-in account user posts a comment it is not visible.
Please check this once

@AlfiyaSiddique
Copy link
Owner

Also, one more thing to add it is visible in the deploy preview but not in the deployed URL:
image

I am opening this issue again @Saurabhchaudhary9799, let me know if you want to work on this, if not will assign to someone else

@Saurabhchaudhary9799
Copy link
Contributor Author

@AlfiyaSiddique , I want to work on this issue . Please don't assign to someone else.

@Saurabhchaudhary9799
Copy link
Contributor Author

Screencast from 2024-10-20 19-07-16.webm
The comments are working properly in local setup.
@AlfiyaSiddique , I want to ask that where have you deployed your backend server

@AlfiyaSiddique
Copy link
Owner

That's confidential. Let me know if any configuration change is needed from my side.
Also, can you share a video where the comments are visible after they are posted from the account and even when the page is refreshed?

@AlfiyaSiddique
Copy link
Owner

Also please test once on the deployed link as well. Some recipes display comments while some do not

@Saurabhchaudhary9799
Copy link
Contributor Author

That's confidential. Let me know if any configuration change is needed from my side. Also, can you share a video where the comments are visible after they are posted from the account and even when the page is refreshed?

Screencast from 2024-10-21 15-10-36.webm
this is the screen recording of comments posting on locally setup.

@Saurabhchaudhary9799
Copy link
Contributor Author

Saurabhchaudhary9799 commented Oct 21, 2024

That's confidential. Let me know if any configuration change is needed from my side. Also, can you share a video where the comments are visible after they are posted from the account and even when the page is refreshed?

Screencast from 2024-10-21 15-10-36.webm this is the screen recording of comments posting on locally setup.

@AlfiyaSiddique , Please check once that there is no error in deploying the server from your side

@AlfiyaSiddique
Copy link
Owner

@Saurabhchaudhary9799 Even in your local video when refreshed the comments disappear. that's the issue

@Saurabhchaudhary9799
Copy link
Contributor Author

Saurabhchaudhary9799 commented Oct 21, 2024

That's confidential. Let me know if any configuration change is needed from my side. Also, can you share a video where the comments are visible after they are posted from the account and even when the page is refreshed?

Screencast from 2024-10-21 15-10-36.webm this is the screen recording of comments posting on locally setup.

hey @AlfiyaSiddique , Please check this video again. It displays every time even after refreshing. The comments are being deleted after clicking delete icon. sorry for my screen recording , in my laptop screen recording , cursor doesn't show.

@AlfiyaSiddique
Copy link
Owner

Okay @Saurabhchaudhary9799 I'll check once from my side

@AlfiyaSiddique AlfiyaSiddique removed bug Something isn't working gssoc-ext For GSSOC Extended Contribution. hacktoberfest-accepted labels Oct 22, 2024
@AlfiyaSiddique AlfiyaSiddique added the bug Something isn't working label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants