Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hass protocol not working after 2024.11 #1468

Open
bradyemerson opened this issue Nov 20, 2024 · 2 comments
Open

hass protocol not working after 2024.11 #1468

bradyemerson opened this issue Nov 20, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@bradyemerson
Copy link

bradyemerson commented Nov 20, 2024

I'm no longer able to retrieve camera feeds via the hass:// protocol after updating Home Assistant to 2024.11. In this version they did significant refactoring of the Camera entity

I believe the issue is that the websocket call to exchange SDP changed from "type": "camera/web_rtc_offer" to "type": "camera/webrtc/offer".
New implementation: home-assistant/core@675ee8e#diff-1afc12e5bc3856abf6faf0dd854e4eb89e0c42de2320f910c4c97071522aa5baR202
(Edit: for some reason the deep links aren't working. File is homeassistant/components/camera/webrtc.py, line 202)

Example of the change in a test: home-assistant/core@675ee8e#diff-5d8717c7e858fd3693aa909ef8a5fb6c31aa503ae7578ceee2844e28e1428870R611
(Edit: File is tests/components/nest/test_camera.py, line 611)

I have not tested this, but I think the change would be here:

"type": "camera/web_rtc_offer",

@AlexxIT AlexxIT added the bug Something isn't working label Nov 20, 2024
@AlexxIT AlexxIT self-assigned this Nov 20, 2024
@felipecrs
Copy link
Contributor

This is a duplicate of #1440, but #1440 is closed already.

@bradyemerson
Copy link
Author

It looks like #1440 was closed by the user switching to the nest protocol. The comments don't appear to address the underlying error in the hass protocol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants