Skip to content

Commit 27f23a0

Browse files
committed
Fix pre-commit failures
1 parent 76d6c9b commit 27f23a0

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

sign-pkg-mac/dmgsettings.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,4 +195,4 @@ def icon_from_app(app_path):
195195
# fi_FI, fr_BE, fr_FR, fr_CA, fr_CH, it_IT, ja_JP, ko_KR, nb_NO, nl_BE,
196196
# nl_NL, pt_BR, pt_PT, ru_RU, sv_SE, zh_CN, zh_TW,
197197

198-
license = None
198+
license = None

sign-pkg-mac/sign.sh

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ set -x -e
2626
# ****************************************************************************
2727
# The following is derived from
2828
# https://federicoterzi.com/blog/automatic-code-signing-and-notarization-for-macos-apps-using-github-actions/
29+
# shellcheck disable=SC2154
2930
base64 --decode > certificate.p12 <<< "$cert_base64"
3031

3132
# We need to create a new keychain, otherwise using the certificate will prompt
@@ -41,6 +42,7 @@ security create-keychain -p "$keychain_pass" viewer.keychain
4142
security set-keychain-settings -lut 21600 viewer.keychain
4243
security default-keychain -s viewer.keychain
4344
security unlock-keychain -p "$keychain_pass" viewer.keychain
45+
# shellcheck disable=SC2154
4446
security import certificate.p12 -k viewer.keychain -P "$cert_pass" -T /usr/bin/codesign
4547
security set-key-partition-list -S 'apple-tool:,apple:,codesign:' -s -k "$keychain_pass" viewer.keychain
4648
rm certificate.p12
@@ -61,6 +63,7 @@ for signee in \
6163
"$plugin_contents"/Frameworks/plugins/*.dat \
6264
"$plugin_contents"/Frameworks/media_plugin_libvlc.dylib
6365
do
66+
# shellcheck disable=SC2154
6467
codesign --verbose --force --timestamp --keychain viewer.keychain \
6568
--sign "$cert_name" "$signee"
6669
done
@@ -100,6 +103,7 @@ do
100103
done
101104

102105
# SLVoice binary
106+
# shellcheck disable=SC2066
103107
for signee in \
104108
"$resources/SLVoice"
105109
do
@@ -125,6 +129,7 @@ do
125129
done
126130

127131
# App Signing
132+
# shellcheck disable=SC2066
128133
for signee in \
129134
"$app_path"
130135
do

0 commit comments

Comments
 (0)