Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no support for HiDPI #1

Open
Alaanor opened this issue Nov 29, 2018 · 6 comments
Open

no support for HiDPI #1

Alaanor opened this issue Nov 29, 2018 · 6 comments

Comments

@Alaanor
Copy link

Alaanor commented Nov 29, 2018

Hi,

First of all, thank for creating this awesome theme, this look really awesome. I've just got to plasma so my issue can be unrelated to your code, if so then feel free to close the issue.

When you set the plasma display scale factor to something else than 1, your theme seems to blur only the part as it this was still in factor 1. (Settings > Display > Scale Display)

Lemme show this through a screenshot.

I currently do not have time to investigate and learn, but if I can, I'll try to find out and make a pull request :)

@Nourepide
Copy link
Contributor

Nourepide commented Nov 29, 2018

Hi, thanks for the feedback.

I think it is Kvantum imperfection.
Blur on the background it is Kwin task, but a request for it receives from Kvantum.

Elements and forms for windows are stored as vector graphics and should be scaled without any problems according to logic. You can see it in master/Akava-Kv/Akava-Kv.svg. But I am not a Kvantum developer and cannot guarantee it.

I'm sorry to admit but it seems I am powerless here.

But if you want to contribute to any project I will accept any help or suggestions.

Thanks again for the feedback.

@Alaanor
Copy link
Author

Alaanor commented Nov 30, 2018

Ok I see, thank you ! I'll try to find some time later (probably in 3 week) to try to fix that. I really want this theme hehe.

@Nourepide
Copy link
Contributor

Can I ask, you tried another Kvantum theme with HDPI?
Kvantum Manager > Change/Delete Theme

This will help to clarify whether I can do something in this situation.

@Alaanor
Copy link
Author

Alaanor commented Dec 1, 2018

Any other theme work, it's just as you said, the blur function who doesn't care about the scale factor.

@Nourepide
Copy link
Contributor

Hm, I can not reproduce it.
Please make sure you are using the latest version of Kvantum and KDE.
This may also be a specific Linux distributions problem.

@Alaanor
Copy link
Author

Alaanor commented Dec 6, 2018

Hmmm, everything was already update. I even reinstalled your theme from a new git clone to be sure I was using the default settings.

Finally I gave up and set the scale back to 1 (not only because of this theme).

Btw I tried quickly here to switch back to scale 1.4 and see if the blur was a problem. I could see that the blur doesn't broke directly, you need to logout to take it effect. (So now you should be able to reproduce)

(Sorry for the late reply, I was kinda (and still) busy these days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants