Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal evaluations export improvements (from 0.29-stable) #12

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mllocs
Copy link
Collaborator

@mllocs mllocs commented Nov 13, 2024

Closes #9

  • Adds pending evaluations to the export (assigned evaluations).
  • Adds "proposal_id", "scope" and "category" columns.

@mllocs mllocs changed the base branch from main to release/0.29-stable November 13, 2024 10:52
@mllocs mllocs marked this pull request as ready for review November 13, 2024 11:19
@mllocs
Copy link
Collaborator Author

mllocs commented Nov 13, 2024

@arnaumonty

Added the new "proposal_id" in the export, it's available in staging already: https://decidim-lot2.populate.tools/admin/participatory_processes/branch-highway/components/4/manage/proposals?q%5Bs%5D=translated_title+asc

Regarding the missing proposal titles and descriptions, I can confirm that when the translation is not available, we don't fallback to the default locale in those exports. I believe this is something that happens in all exports.

Also, I tried exporting to Excel and worked now. 🙌

@arnaumonty
Copy link
Collaborator

@arnaumonty

Added the new "proposal_id" in the export, it's available in staging already: https://decidim-lot2.populate.tools/admin/participatory_processes/branch-highway/components/4/manage/proposals?q%5Bs%5D=translated_title+asc

Regarding the missing proposal titles and descriptions, I can confirm that when the translation is not available, we don't fallback to the default locale in those exports. I believe this is something that happens in all exports.

Also, I tried exporting to Excel and worked now. 🙌

Great! It works perfect :) Thanks @mllocs

Copy link

@fblupi fblupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you doing the PR against the release/0.29-stable branch. Is it because these changes don't make sense in decidim >0.29?

If that's not the case, I would do this PR against main and then backport it to release/0.29-stable and release/0.28-stable if needed.

@mllocs mllocs changed the base branch from release/0.29-stable to main November 15, 2024 09:59
@mllocs mllocs force-pushed the feat/improve-internal-evaluation-export-from-0.29-stable branch from 328d6de to b88c2f5 Compare November 15, 2024 10:01
@mllocs
Copy link
Collaborator Author

mllocs commented Nov 15, 2024

Why are you doing the PR against the release/0.29-stable branch. Is it because these changes don't make sense in decidim >0.29?

@fblupi It was mostly for convenience, this way it was easier to merge into our staging which uses [email protected]. I rebased the PR and pointed it to main. Ready to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add in the export of internal evaluations all the evaluations including those that has not been done.
4 participants