Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker file is incomplete/inconsistent #183

Open
jsperezg opened this issue Jan 1, 2018 · 3 comments
Open

Docker file is incomplete/inconsistent #183

jsperezg opened this issue Jan 1, 2018 · 3 comments

Comments

@jsperezg
Copy link

jsperezg commented Jan 1, 2018

🎩 User Story

Docker file specifies that image should be built on top of ruby 2.4.0 but Gem file specifies that the minimum version is 2.4.2.

Another problem that I've found trying to run it from docker in my computer is that the gem decidim-dataviz is not being referenced during the image construction which causes the command bundle install to fail.

Docker file should change the first line to reference the right ruby version:

FROM ruby:2.4.2

Additionally it should import the databiz engine:

ADD ./decidim-dataviz/decidim-dataviz.gemspec /tmp/decidim-dataviz/decidim-dataviz.gemspec

@jsperezg
Copy link
Author

jsperezg commented Jan 1, 2018

command should be moved to docker-compose file as well.

@josepjaume
Copy link
Contributor

Oh yeah, this Dockerfile isn't well maintained, as we're not developing on docker locally :(. We've since created a decidim official image for both development (and CI) and production. Maybe we could migrate to that one: https://hub.docker.com/r/decidim/decidim/

@oalonson
Copy link

oalonson commented Jun 6, 2019

Any action in this issue since Jan 2018? solved? could it be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants