New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Useless variables added to functions/routines arguments after conversion to stics target platform #223

Open

plecharpent opened this issue Apr 25, 2024 · 0 comments

plecharpent commented Apr 25, 2024

Not only in an init routine, exogenous variables are added to signatures but not used in functions body or are duplicates.

Here are 2 examples for Stics modules translation to fortran:

Soil temperature model
- original code

!%%CyML Composition Begin%%
 SUBROUTINE model_soil_temp(prev_temp_profile, &
                             prev_canopy_temp, &
                             min_canopy_temp, &
                             max_canopy_temp, &
                             min_air_temp, &
                             layer_thick, &
                             temp_profile, &
                             layer_temp)

generated code

SUBROUTINE model_soil_temp(min_temp, &
        max_temp, &
        prev_temp_profile, &
        prev_canopy_temp, &
        min_air_temp, &
        air_temp_day1, &
        layer_thick, &
        min_canopy_temp, &
        max_canopy_temp, &
        temp_amp, &
        temp_profile, &
        layer_temp, &
        canopy_temp_avg)

Soil profile init routine
- original code

SUBROUTINE init_temp_profile(air_temp_day1, layer_thick, &
                                prev_temp_profile, prev_canopy_temp)

generated code

SUBROUTINE init_temp_profile(min_air_temp, &
        air_temp_day1, &
        layer_thick, &
        temp_amp, &
        prev_temp_profile, &
        prev_canopy_temp)
``

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment