Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading Luxon to v3 #463

Open
EliezerB123 opened this issue Jan 16, 2024 · 0 comments
Open

Upgrading Luxon to v3 #463

EliezerB123 opened this issue Jan 16, 2024 · 0 comments

Comments

@EliezerB123
Copy link

Any chance you've given any thought to upgrading Luxon to v2.5 or v3.0? (Or even v3.4)

There's a migration guide here, if it helps: https://moment.github.io/luxon/#upgrading

The reason I say that is because luxon added support for ESM-style imports in v2.5, which will get rid of these errors:

node_modules\ngx-material-timepicker\fesm2015\ngx-material-timepicker.js depends on 'luxon'. CommonJS or AMD dependencies can cause optimization bailouts.

For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

image

I understand this is a not insignificant migration, but if you're looking at it, that would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant