Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace otel-trace with otel-context-aware-slog in integration test #10798

Open
mhofman opened this issue Jan 4, 2025 · 1 comment · May be fixed by #10864
Open

Replace otel-trace with otel-context-aware-slog in integration test #10798

mhofman opened this issue Jan 4, 2025 · 1 comment · May be fixed by #10864
Assignees
Labels
enhancement New feature or request telemetry

Comments

@mhofman
Copy link
Member

mhofman commented Jan 4, 2025

What is the Problem Being Solved?

We don't currently use any of the otel tracing reporting (both because it's missing capabilities and because we no longer have a good frontend for it), and I believe we stopped using it in instagoric. However we've introduced a context aware slog that we started using.

Description of the Design

Replace otel-trace with otel-context-aware-slog in the integration test

Consider removing otel-and-flight-recorder.js as well.

Security Considerations

None

Scaling Considerations

None

Test Plan

None

Upgrade Considerations

Slog senders are part of chain software

@usmanmani1122
Copy link
Contributor

@mhofman I don't see otel-and-flight-recorder.js used anywhere. Should we remove the slogger all together?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request telemetry
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants