Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise state-sync snapshot payload size to accommodate 8 weeks of wallet factory leak #10740

Closed
mhofman opened this issue Dec 18, 2024 · 1 comment
Assignees
Labels
agoric-cosmos enhancement New feature or request state-sync state sync related

Comments

@mhofman
Copy link
Member

mhofman commented Dec 18, 2024

What is the Problem Being Solved?

To address #8325 we previously raised the state-sync payload size form 64MB to 512 MB. However because we currently have a leak in the board and the wallet factory vats, mainnet blew over that limit and state-sync snapshots can no longer be restored. The board vat leak has been identified and fixed, but we still haven't diagnosed the wallet factory leak, so until such time we need to accommodate it.

Description of the Design

Raise the state-sync snapshot payload size to a number sufficient to cover the expected heap snapshot size of the of the leaking wallet factory vat running for 8 weeks. That number is likely about 1GB.

Security Considerations

I believe the limit exists to avoid a state-sync snapshot fetched from an untrusted peer cannot blow up the disk usage of the node. 1GB in that case is likely no more a problem than 512MB.

Scaling Considerations

None

Test Plan

Already tested raising this limit locally in a modified follower restoring from state-sync. #8325 included a test verifying the limit applies as expected.

Upgrade Considerations

Distributed as a chain software upgrade but does not affect consensus.

@mhofman
Copy link
Member Author

mhofman commented Dec 22, 2024

Now that #10706 has a planned fixed for u18, this is no longer needed.

@mhofman mhofman closed this as not planned Won't fix, can't repro, duplicate, stale Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agoric-cosmos enhancement New feature or request state-sync state sync related
Projects
None yet
Development

No branches or pull requests

2 participants