Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjustVideoProfile.js contains incorrect comments #3

Open
yamasite opened this issue Apr 19, 2021 · 3 comments
Open

adjustVideoProfile.js contains incorrect comments #3

yamasite opened this issue Apr 19, 2021 · 3 comments

Comments

@yamasite
Copy link
Contributor

The comment here applies to Web SDK 3.x only:

// you can find all the agora preset video profiles here https://docs.agora.io/cn/Voice/API%20Reference/web/interfaces/agorartc.stream.html#setvideoprofile
var videoProfiles = [
  { label: "480p_1", detail: "640×480, 15fps, 500Kbps", value: "480p_1" },
  { label: "480p_2", detail: "640×480, 30fps, 1000Kbps", value: "480p_2" },
  { label: "720p_1", detail: "1280×720, 15fps, 1130Kbps", value: "720p_1" },
  { label: "720p_2", detail: "1280×720, 30fps, 2000Kbps", value: "720p_2" },
  { label: "1080p_1", detail: "1920×1080, 15fps, 2080Kbps", value: "1080p_1" },
  { label: "1080p_2", detail: "1920×1080, 30fps, 3000Kbps", value: "1080p_2" },
  { label: "200×640", detail: "200×640, 30fps", value: { width: 200, height: 640, frameRate: 30 } } // custom video profile
]

The link for Web SDK 4.x is: https://docs.agora.io/cn/Video/API%20Reference/web_ng/globals.html#videoencoderconfigurationpreset

@yoreland
Copy link
Contributor

thanks for report will check and update

@yamasite
Copy link
Contributor Author

Also, the markdown files in the Docs folder are out of date and can just be removed. Otherwise, they might be misleading.

@yoreland
Copy link
Contributor

Your comments will be included in next repo update.
Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants