Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AGE-230] [Bug] Start from code can fail if user has a .dockerignore or Dockerfile #1738

Open
mmabrouk opened this issue Jun 2, 2024 · 0 comments · May be fixed by #1739
Open

[AGE-230] [Bug] Start from code can fail if user has a .dockerignore or Dockerfile #1738

mmabrouk opened this issue Jun 2, 2024 · 0 comments · May be fixed by #1739
Assignees
Labels
bug Something isn't working Low priority Created by Linear-GitHub Sync
Milestone

Comments

@mmabrouk
Copy link
Member

mmabrouk commented Jun 2, 2024

There are cases where the user has already a Dockerfile or .dockerignore file in their code folder. In these cases, we current overwrite their Dockerfile and might use their .dockerignore.

We need to make sure to:

  1. Not to overwrite their Dockerfile, but calling our Dockerfile differently
  2. Not copy their .dockerignore file if existing

From SyncLinear.com | AGE-230

@mmabrouk mmabrouk self-assigned this Jun 2, 2024
@mmabrouk mmabrouk added bug Something isn't working Low priority Created by Linear-GitHub Sync labels Jun 2, 2024
@mmabrouk mmabrouk linked a pull request Jun 2, 2024 that will close this issue
@mmabrouk mmabrouk modified the milestones: v.48, v.49 Jun 2, 2024
@mmabrouk mmabrouk modified the milestones: v.49, v.50, Bugs Jun 16, 2024
@mmabrouk mmabrouk modified the milestones: Bugs, v.51 Jun 23, 2024
@mmabrouk mmabrouk modified the milestones: v.51, v.52 Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Low priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant