fix: Updated the startup and shutdown events, now they are using life…#631
fix: Updated the startup and shutdown events, now they are using life…#631DebanKsahu wants to merge 3 commits into
Conversation
santoshkumarradha
left a comment
There was a problem hiding this comment.
Thanks for taking this on. Moving off the deprecated startup/shutdown hooks is the right direction. I left one blocker inline because this version replaces the app lifespan outright, which can break callers that already pass their own FastAPI lifespan into Agent.
Performance
✓ No regressions detected |
📊 Coverage gateThresholds from
✅ Gate passedNo surface regressed past the allowed threshold and the aggregate stayed above the floor. |
📐 Patch coverage gateThreshold: 80% on lines this PR touches vs
✅ Patch gate passedEvery surface whose lines were touched by this PR has patch coverage at or above the threshold. |
Summary
I changed the startup and shutdown events from python sdk. Previously it was using deprecated
on_event()method but I replaced it with lifespan which handle both shutdown and startup event.Type of change
Test plan
./scripts/test-all.sh./scripts/coverage-summary.shwas run locally, but it currently stops at sdk-python because the local.venvis missingpip.upstream/main.Before asking for review, please confirm:
coverage-baseline.jsoninthis PR only if the removal caused a legitimate regression and I
called it out in the summary above.
Checklist
docs/DEVELOPMENT.md.
Related issues / PRs
Fixes #628