Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Efficiency suggestion: Don't re-read climate for each crop #2

Open
samsrabin opened this issue Sep 23, 2022 · 1 comment
Open

Efficiency suggestion: Don't re-read climate for each crop #2

samsrabin opened this issue Sep 23, 2022 · 1 comment

Comments

@samsrabin
Copy link
Member

It seems inefficient to call 01_calc_crop_calendars.R for every crop, as it results in the climate forcings needing to be read over and over. Instead, it seems like it'd be more efficient to loop through all crops in 01_calc_crop_calendars.R itself. Unless I'm misunderstanding something?

(@minoli-pik Tagging you as requested to make sure you see this.)

@minoli-pik
Copy link
Member

Thanks Sam! Yes, good point, that makes totally sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants