Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site A Button images don’t change as expected #4

Open
3 tasks done
SourasishBasu opened this issue Oct 1, 2023 · 0 comments
Open
3 tasks done

Site A Button images don’t change as expected #4

SourasishBasu opened this issue Oct 1, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@SourasishBasu
Copy link
Collaborator

Button Images do not change on button press.

Summary

Button images don't toggle between green and grey when pressed and stay grey by default.

Details

→ On the Site A screen, there will be a 3x3 grid of buttons. The buttons may be pressed to toggle their state between on (green)/off (grey).

→ There might be a situation where the button images do not show up as intended. While pressing any button instead of toggling its state between green/grey it remains grey as though we never clicked the button. This prevents you from understanding what button has been clicked and what not.

→ For Ex:- You need to enter the passcode 1762 and you accidentally pressed a wrong button. You have no way of knowing what button has been pressed.

→ Button image toggle is controlled by the root.change_img(self, button, idOG=<button_id>) function in the siteA.py file under the SiteAScreen class. The current state of the button image is controlled by the if-else conditions within the widget.source variable of the change_img function referencing the on.png and off.png for the green and grey images of the buttons respectively. Recheck the condition and fix necessary values within the variable.

Additional Information

Screenshots (if applicable)

image

Checklist

  • I have searched existing issues to ensure this is not a duplicate.
  • I have provided clear and detailed information about the issue.
  • I have included any necessary screenshots or files.

@SourasishBasu SourasishBasu changed the title Button images don’t change as expected Site A Button images don’t change as expected Oct 1, 2023
ritankar56 added a commit to ritankar56/octops that referenced this issue Oct 2, 2023
@Afterdie Afterdie added the good first issue Good for newcomers label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants