You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Naming could be improved across the project. Among other things:
"assumed" should be renamed to "built-in";
Id is a confusing suffix for a rust user: it normally designates integer identifiers only;
Similarly, Raw is used in places where a rust user would naturally use a Kind suffix, e.g. TerminatorKind;
Traits and clauses and predicates are subtle things, I think better names would help follow what's happening. E.g. TraitInstanceRef instead of TraitRef, TraitClause or TraitBound instead of TraitDeclRef, something else instead of TraitClause.
Names don't always match between the rust and ocaml sides. Once we're happy with the rust side we should propagate the changes.
The text was updated successfully, but these errors were encountered:
Naming could be improved across the project. Among other things:
Id
is a confusing suffix for a rust user: it normally designates integer identifiers only;Raw
is used in places where a rust user would naturally use aKind
suffix, e.g.TerminatorKind
;TraitInstanceRef
instead ofTraitRef
,TraitClause
orTraitBound
instead ofTraitDeclRef
, something else instead ofTraitClause
.The text was updated successfully, but these errors were encountered: